Bug 13220 - [S60] Browser doesn't support for embedded DRM image content.
Summary: [S60] Browser doesn't support for embedded DRM image content.
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 523.x (Safari 3)
Hardware: S60 Emulator S60 3rd edition
: P2 Critical
Assignee: Nobody
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2007-03-28 14:18 PDT by Hong Zhao
Modified: 2011-03-21 11:53 PDT (History)
0 users

See Also:


Attachments
Add DRM image decoder support for OSS Browser. (9.42 KB, patch)
2007-03-28 14:54 PDT, Hong Zhao
yongjun.zhang: review-
Details | Formatted Diff | Diff
Add DRM image decode support for 3.2 (5.95 KB, patch)
2007-03-28 15:09 PDT, Hong Zhao
no flags Details | Formatted Diff | Diff
Make some changes based on the review comments. (10.35 KB, patch)
2007-03-29 09:19 PDT, Hong Zhao
yongjun.zhang: review-
Details | Formatted Diff | Diff
Remove the redundant part in change log block. (9.78 KB, patch)
2007-03-29 09:46 PDT, Hong Zhao
yongjun.zhang: review-
Details | Formatted Diff | Diff
Add DRM image decode function for 3.1m. (6.34 KB, patch)
2007-03-29 10:41 PDT, Hong Zhao
yongjun.zhang: review+
Details | Formatted Diff | Diff
Add function to decode DRM image content in 3.2. (6.24 KB, patch)
2007-03-29 11:51 PDT, Hong Zhao
yongjun.zhang: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hong Zhao 2007-03-28 14:18:07 PDT
Some images crash when browsing some wap page. 

These images are converted to DRM content by server. They are not supported in the current Browser. So Browser displays the broken images.

TSW# ID:  TKWG-6Z59YX
Comment 1 Hong Zhao 2007-03-28 14:54:45 PDT
Created attachment 13851 [details]
Add DRM image decoder support for OSS Browser.
Comment 2 Hong Zhao 2007-03-28 15:09:27 PDT
Created attachment 13852 [details]
Add DRM image decode support for 3.2
Comment 3 Yongjun Zhang 2007-03-29 07:06:53 PDT
Comment on attachment 13851 [details]
Add DRM image decoder support for OSS Browser.

The fix is incorrect:
1. function name "DisplayDRMImageL" needs to be something like "DecodeDRMImageL" because you just decode DRM image in this function.
2. the condition to trigger DRM encoding is wrong - any error image (no matter is drm or now) will trigger DRM decoding.
3. Performance is very bad because DisplayDRMImageL is called very time when a decoding error occurs.
4. Don't use sychrous decoding, WaitForRequest will block the active object and the whole image deocoder halts.
5. The whole idea of StaticImagedecoder is to reuse the Bufferdecoder, should not create another  buffered decoder for drm images.
Comment 4 Hong Zhao 2007-03-29 09:19:23 PDT
Created attachment 13864 [details]
Make some changes based on the review comments.
Comment 5 Yongjun Zhang 2007-03-29 09:41:15 PDT
Comment on attachment 13864 [details]
Make some changes based on the review comments.

remove the redundant change log block.
Comment 6 Hong Zhao 2007-03-29 09:46:09 PDT
Created attachment 13865 [details]
Remove the redundant part in change log block.
Comment 7 Yongjun Zhang 2007-03-29 10:04:02 PDT
Comment on attachment 13865 [details]
Remove the redundant part in change log block.

why webkit.mmp is changed from __GCCE__ to __BROWSER_SDK?
Comment 8 Hong Zhao 2007-03-29 10:41:23 PDT
Created attachment 13867 [details]
Add DRM image decode function for 3.1m.
Comment 9 Yongjun Zhang 2007-03-29 10:51:05 PDT
Comment on attachment 13867 [details]
Add DRM image decode function for 3.1m.

r=me
Comment 10 Yongjun Zhang 2007-03-29 10:51:43 PDT
Committed on revision 20576.
Comment 11 Hong Zhao 2007-03-29 11:51:40 PDT
Created attachment 13872 [details]
Add function to decode DRM image content in 3.2.
Comment 12 Yongjun Zhang 2007-03-29 13:21:41 PDT
Comment on attachment 13872 [details]
Add function to decode DRM image content in 3.2.

r = me
Comment 13 Bradley Morrison 2008-04-09 11:39:46 PDT
Bulk closing of all s60 platform bugs. 

Sorry for the noise!
Comment 14 Joel Parks 2011-03-21 11:53:18 PDT
re-purposing InTSW keyword for use by QtWebkit team