Bug 13204 – Submit initial version of mac project files for apollo port of WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Chris Brichford]

Bug to track submission of mac project files for apollo port of WebCore.  Project files just build derived sources at this point, so I can move them easily if they are in the wrong spot.

[Chris Brichford]

Created attachment 13830 [details]
Patch to add mac project files for apollo port of WebCore

[Adam Roben (:aroben)]

Comment on attachment 13830 [details]
Patch to add mac project files for apollo port of WebCore

What is the purpose of the WebCore directory beneath the mac directory?

[Chris Brichford]

When you tell xcode to make a new project and you give it a directory to make the project in it will always create a sub-directory named the same as the project, unless the base name of the directory you choose is the same as the project name.

The JSCore project files I submitted have the same structure.

[Timothy Hatcher]

Comment on attachment 13830 [details]
Patch to add mac project files for apollo port of WebCore

Yes, Xcode does add this extra WebCore subdirectory, but you don't need to keep that structure. Please remove the extra subdirectory. The JavaScriptCore version should not have an extra subdirectory either.

[Timothy Hatcher]

Does the *.apolloproj file extension map to an application? Or is it just a naming convention?

[Timothy Hatcher]

Is there any way to do this without needing a copy of the whole Xcode project file? What is different about the Apollo project file and the main project file?

It would make life easier if there was one true project file. Otherwise, the Apollo build will break if files are added or removed on the main project.

[Chris Brichford]

apolloproj is just a naming convention ( hyatt came up with it ).

We want our own project file for the following reasons:
  1.  Apollo project builds a static lib instead of a framework.
  2.  We do not want to build all the SVG code into our static lib.
  3.  We will have different pre-processor macros turned on.
  4.  We will have different set of platform files for the apollo port.
  5.  We want to isolate our changes from the rest of webcore as much as possible so that we are unlikely to break the mac port.

Strictly speaking the xcode project could be shared, but we have a new target and probably new configurations.  So to avoid build breakage submitters would have to build those anyway.  Once they are building something new it might as well be in a seperate project file.

I don't think the vcproj could be shared on windows.

[Chris Brichford]

I'm also ok with the project file breaking from time to time.  Our daily build will be using a copy of the code in our internal version control system ( perforce ) which we will integrate to and from the svn repository.  When we do those integrates we will fix the build if needed.

We may setup a build bot to notify people that the apollo build broke, but we don't expect everyone to keep our port's project files up to date for us.

[Chris Brichford]

Created attachment 13847 [details]
New patch.  Puts mac project files in better location.

[Mark Rowe (bdash)]

Landed in r21135.  Sorry for the delay.