RESOLVED FIXED 13165
Using BUILDING_ON_TIGER in WebKit instead of local tests 
https://bugs.webkit.org/show_bug.cgi?id=13165
Summary Using BUILDING_ON_TIGER in WebKit instead of local tests
David Kilzer (:ddkilzer)
Reported 2007-03-22 16:57:34 PDT
Use the BUILDING_ON_TIGER macro in WebKitPrefix.h instead of scattering the same test throughout the code.
Attachments
Patch v1 (3.27 KB, patch)
2007-03-22 16:59 PDT, David Kilzer (:ddkilzer) 		darin: review-
DetailsFormatted DiffDiff
Patch v2 (1.41 KB, patch)
2007-03-22 17:11 PDT, David Kilzer (:ddkilzer) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2007-03-22 16:59:00 PDT
Created attachment 13771 [details] Patch v1
Darin Adler
Comment 2 2007-03-22 17:00:33 PDT
Comment on attachment 13771 [details] Patch v1 The changes to header files are incorrect! BUILDING_ON_TIGER is defined when building WebKit, but not by WebKit clients when including WebKit headers.
David Kilzer (:ddkilzer)
Comment 3 2007-03-22 17:02:07 PDT
Marking as INVALID since this can't be done.
David Kilzer (:ddkilzer)
Comment 4 2007-03-22 17:03:08 PDT
One of the changes may be landed.
David Kilzer (:ddkilzer)
Comment 5 2007-03-22 17:11:03 PDT
Created attachment 13772 [details] Patch v2 Exclude public headers which don't get WebKitPrefix.h when building from clients.
Darin Adler
Comment 6 2007-03-22 17:19:13 PDT
Comment on attachment 13772 [details] Patch v2 looks fine, r=me
David Kilzer (:ddkilzer)
Comment 7 2007-03-22 17:31:43 PDT
Committed revision 20412.
Note You need to log in before you can comment on or make changes to this bug.