Bug 13165 - Using BUILDING_ON_TIGER in WebKit instead of local tests
Summary: Using BUILDING_ON_TIGER in WebKit instead of local tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-22 16:57 PDT by David Kilzer (:ddkilzer)
Modified: 2007-03-22 17:31 PDT (History)
0 users

See Also:

Attachments
Patch v1 (3.27 KB, patch)
2007-03-22 16:59 PDT, David Kilzer (:ddkilzer) 		darin: review-
Details | Formatted Diff | Diff
Patch v2 (1.41 KB, patch)
2007-03-22 17:11 PDT, David Kilzer (:ddkilzer) 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2007-03-22 16:57:34 PDT 
Use the BUILDING_ON_TIGER macro in WebKitPrefix.h instead of scattering the same test throughout the code.
Comment 1 David Kilzer (:ddkilzer) 2007-03-22 16:59:00 PDT 
Created attachment 13771 [details]
Patch v1
Comment 2 Darin Adler 2007-03-22 17:00:33 PDT 
Comment on attachment 13771 [details]
Patch v1

The changes to header files are incorrect!

BUILDING_ON_TIGER is defined when building WebKit, but not by WebKit clients when including WebKit headers.
Comment 3 David Kilzer (:ddkilzer) 2007-03-22 17:02:07 PDT 
Marking as INVALID since this can't be done.
Comment 4 David Kilzer (:ddkilzer) 2007-03-22 17:03:08 PDT 
One of the changes may be landed.
Comment 5 David Kilzer (:ddkilzer) 2007-03-22 17:11:03 PDT 
Created attachment 13772 [details]
Patch v2

Exclude public headers which don't get WebKitPrefix.h when building from clients.
Comment 6 Darin Adler 2007-03-22 17:19:13 PDT 
Comment on attachment 13772 [details]
Patch v2

looks fine, r=me
Comment 7 David Kilzer (:ddkilzer) 2007-03-22 17:31:43 PDT 
Committed revision 20412.