Bug 13140 - Crash after loading SVG fragment with XMLHttpRequest (Yosemite Map Geology Layer)
Summary: Crash after loading SVG fragment with XMLHttpRequest (Yosemite Map Geology La...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Alexey Proskuryakov
URL: http://www.carto.net/neumann/webkitsv...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-21 06:19 PDT by Andreas Neumann
Modified: 2007-03-21 12:25 PDT (History)
1 user (show)

See Also:


Attachments
crashlog for yosemite geology loading (24.91 KB, text/plain)
2007-03-21 06:24 PDT, Andreas Neumann
no flags Details
proposed fix (2.43 KB, patch)
2007-03-21 11:59 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed fix (3.68 KB, patch)
2007-03-21 12:00 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
proposed fix (4.22 KB, patch)
2007-03-21 12:07 PDT, Alexey Proskuryakov
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Neumann 2007-03-21 06:19:40 PDT
If you load this SVG file and click on the text (geology layer) an XMLHttpRequest() is generated and a SVG fragment added to the DOM. During or after loading Webkit crashes. I don't know if this bug is SVG related, DOM related or an XML parser problem. It somehow has to do with the content that is loaded, because it crashes on the geology layer, but not on other layers, like hydrology.

A crashlog will be attached.
Comment 1 Andreas Neumann 2007-03-21 06:24:28 PDT
Created attachment 13734 [details]
crashlog for yosemite geology loading
Comment 2 David Kilzer (:ddkilzer) 2007-03-21 08:55:33 PDT
P1 crashers need a Radar, too! :)

Comment 3 Alexey Proskuryakov 2007-03-21 11:59:15 PDT
Created attachment 13743 [details]
proposed fix

I still don't really understand why xhr.responseXML has to create a full SVG (or XHTML) DOM, but ok...
Comment 4 Alexey Proskuryakov 2007-03-21 12:00:23 PDT
Created attachment 13744 [details]
proposed fix

Forgot to include chagnelogs.
Comment 5 Alexey Proskuryakov 2007-03-21 12:07:25 PDT
Created attachment 13745 [details]
proposed fix

So, I didn't even notice reportWarning next to reportError :(

Thanks, Mitz!
Comment 6 mitz 2007-03-21 12:11:37 PDT
Comment on attachment 13745 [details]
proposed fix

r=me

I think according to the style guidelines the outer ifs should have braces.
Comment 7 Alexey Proskuryakov 2007-03-21 12:25:30 PDT
Committed revision 20363.

I do not know if it's correct for d="" to emit an error message, but the crasher is fixed now.