pass Frame context to ChromeClient::createWindow and friends

[Darin Fisher (:fishd, Google)]

pass Frame context to ChromeClient::createWindow and friends

currently, it is not possible to know what Frame is trying to open a window.  it would be nice if there were a Frame pointer passed to createWindow and createModalDialog.  runJavaScriptAlert and friends already have such a Frame pointer, so this change would just make the other methods on ChromeClient consistent.

[Darin Fisher (:fishd, Google)]

<ggaren> morganL: what would you use the context for?
<morganL> ggaren: i would like to know which frame wants to open a window
<morganL> ggaren: similar to how runJavaScriptAlert is given a Frame pointer
<ggaren> morganL: that seems reasonable

[Darin Fisher (:fishd, Google)]

Created attachment 13715 [details]
patch

A straightforward little patch.

[Maciej Stachowiak]

Comment on attachment 13715 [details]
patch

- This breaks the Qt build, would be better not to do that.

- Since the Frame argument is currently unused, it would be good to add a comment noting not to remove it, since people otherwise remove apparently dead code.

r- for these two issues, otherwise works fine.

[Darin Fisher (:fishd, Google)]

Created attachment 13750 [details]
revised patch

Revised as requested.  Thanks!

[Maciej Stachowiak]

Comment on attachment 13750 [details]
revised patch

r=me

Committers, please let someone from Apple land this patch.

[Mark Rowe (bdash)]

Landed in r20856.