Bug 13123 - CSS selectors that use :lang, :not, and namespaces do not serialize correctly
Summary: CSS selectors that use :lang, :not, and namespaces do not serialize correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-19 16:15 PDT by Darin Adler
Modified: 2007-03-24 20:04 PDT (History)
0 users

See Also:

Attachments
patch, with change log and test case (12.64 KB, patch)
2007-03-19 16:16 PDT, Darin Adler 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2007-03-19 16:15:00 PDT 
CSS selectors that use :lang, :not, and namespaces do not serialize correctly. I noticed this while working on another bug awhile back and created a test case and fixes.
Comment 1 Darin Adler 2007-03-19 16:16:03 PDT 
Created attachment 13709 [details]
patch, with change log and test case
Comment 2 mitz 2007-03-20 06:48:46 PDT 
Comment on attachment 13709 [details]
patch, with change log and test case

The outer if block needs braces.

+    if (m_match == CSSSelector::None || !prefix.isNull() || localName != starAtom)
+        if (prefix.isNull())
+            str = localName;
+        else
+            str = prefix + "|" + localName;

r=me
Comment 3 Darin Adler 2007-03-24 20:04:16 PDT 
Committed revision 20477.