Bug 13122 - No history added for a window.open followed by refresh
Summary: No history added for a window.open followed by refresh
Status: RESOLVED DUPLICATE of bug 3546
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 523.x (Safari 3)
Hardware: All OS X 10.4
: P2 Major
Assignee: Nobody
URL:
Keywords: GoogleBug
Depends on:
Blocks:
 
Reported: 2007-03-19 15:56 PDT by Dex Deacon
Modified: 2007-04-19 05:32 PDT (History)
2 users (show)

See Also:


Attachments
reduced test case (254 bytes, text/html)
2007-03-19 15:57 PDT, Dex Deacon
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dex Deacon 2007-03-19 15:56:16 PDT
Repro steps:
1. Navigate to the attached test case.
2. Click the button to open a new window.
3. Navigate somewhere in the new window.  Notice that you can't go back to the original page that opened the window.

Firefox creates a history entry for the new page opened, Safari does not.  I observed this in both Safari 2.0.4 and Safari running with WebKit r20325.

From stepping through the code, it looks like the problem is in FrameLoader::updateHistoryForStandardLoad().  For the initial window.open(), the URL is empty, so history is not updated.  Then the redirect occurs, and this function is called again, but this time it's rejected from history because it's a redirect.
Comment 1 Dex Deacon 2007-03-19 15:57:21 PDT
Created attachment 13707 [details]
reduced test case
Comment 2 Darin Fisher (:fishd, Google) 2007-04-18 15:40:16 PDT
The problem here is that no session history entry is created for either "about:blank" navigations or "client redirect" navigations.  The <meta refresh> appears to be treated as a client redirect.

I see this bug when I click a link in Gmail.  IMO, this is a pretty major bug.
Comment 3 Brady Eidson 2007-04-18 15:45:22 PDT
I *think* this is a dupe of http://bugs.webkit.org/show_bug.cgi?id=3546 which was fixed very recently
Comment 4 Brady Eidson 2007-04-18 15:48:56 PDT
Yep, its a dupe - this works on ToT.  Closing.
Comment 5 David Kilzer (:ddkilzer) 2007-04-19 05:32:40 PDT
Reopening to mark as duplicate.

Comment 6 David Kilzer (:ddkilzer) 2007-04-19 05:32:54 PDT

*** This bug has been marked as a duplicate of 3546 ***