RESOLVED FIXED 13084
ASSERTION FAILED: !m_clients.contains(c) in WebCore::CachedResource::ref(WebCore::CachedResourceClient*) 
https://bugs.webkit.org/show_bug.cgi?id=13084
Summary ASSERTION FAILED: !m_clients.contains(c) in WebCore::CachedResource::ref(WebC...
mitz
Reported 2007-03-15 11:49:46 PDT
I hit the above assertion every time I open the URL.
Attachments
Reduction (will assert) (122 bytes, text/html)
2007-03-16 06:34 PDT, mitz 		no flags
Details
Add a method to get all images used by a renderer (34.47 KB, patch)
2007-03-16 08:45 PDT, mitz 		hyatt: review-
DetailsFormatted DiffDiff
Convert to using a counted set in the cache. (3.01 KB, patch)
2007-03-16 14:49 PDT, Dave Hyatt 		andersca: review+
DetailsFormatted DiffDiff
Tweak imageChanged in RenderImage and RenderListMarker (4.20 KB, patch)
2007-03-16 15:23 PDT, Dave Hyatt 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2007-03-16 06:34:22 PDT
Created attachment 13665 [details] Reduction (will assert)
mitz
Comment 2 2007-03-16 08:25:02 PDT
Working on it...
mitz
Comment 3 2007-03-16 08:45:57 PDT
Created attachment 13667 [details] Add a method to get all images used by a renderer I didn't change RenderListMarker, which ref()s its image if it has one, because list markers cannot have box decorations. I could do that for consistency if you think that's better.
Dave Hyatt
Comment 4 2007-03-16 14:38:32 PDT
Comment on attachment 13667 [details] Add a method to get all images used by a renderer I disagree with the idea of minimizing refs and derefs, since refs even on the same image need to count as accesses of the image. However it is true that the same resource should not be getting multiple notifications for the same image load. I think a better way to solve this problem is to convert the cached resource client set to be a counted set. That way multiple refs and derefs can still occur and we can still have meaningful asserts.
Dave Hyatt
Comment 5 2007-03-16 14:39:17 PDT
I will take care of this.
Dave Hyatt
Comment 6 2007-03-16 14:49:48 PDT
Created attachment 13670 [details] Convert to using a counted set in the cache.
Anders Carlsson
Comment 7 2007-03-16 15:11:34 PDT
Comment on attachment 13670 [details] Convert to using a counted set in the cache. r=me
Dave Hyatt
Comment 8 2007-03-16 15:23:19 PDT
Created attachment 13673 [details] Tweak imageChanged in RenderImage and RenderListMarker
Anders Carlsson
Comment 9 2007-03-16 15:24:49 PDT
Comment on attachment 13673 [details] Tweak imageChanged in RenderImage and RenderListMarker r=me
mitz
Comment 10 2007-03-17 06:49:15 PDT
Comment on attachment 13673 [details] Tweak imageChanged in RenderImage and RenderListMarker Landed <http://trac.webkit.org/projects/webkit/changeset/20242>
Dave Hyatt
Comment 11 2007-03-18 14:42:30 PDT
Fixed.
Note You need to log in before you can comment on or make changes to this bug.