Bug 13082 – Gdk build fix

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Shrikant Gangoda]

g++ -c -o obj-gnu/webcore_gdk_EditorClientGdk.o -I../../../JavaScriptCore -I../.. -I../../bindings/js -I../../bridge -I../../css -I../../DerivedSources/WebCore -I../../dom -I../../editing -I../../ForwardingHeaders/kjs -I../../history -I../../html -I../../include -I../../loader -I../../loader/gdk -I../../loader/icon -I../../page -I../../platform -I../../platform/graphics -I../../platform/graphics/gdk -I../../platform/image-decoders -I../../platform/image-decoders/bmp -I../../platform/image-decoders/gif -I../../platform/image-decoders/ico -I../../platform/image-decoders/jpeg -I../../platform/image-decoders/png -I../../platform/image-decoders/xbm -I../../platform/image-decoders/zlib -I../../platform/network -I../../platform/network/gdk -I../../rendering -I../../xml -DENABLE_XSLT=1 -DLINUX -DUSE_CONSERVATIVE_GC=0 -DHAVE_FUNC_ISNAN -D_THREAD_SAFE -pthread -g -I../../platform/gdk -I../../platform/network/gdk -DBUILDING_GDK__ -DBUILDING_CAIRO__ -Iplatform/gdk -Iplatform/graphics/cairo -DENABLE_XPATH -I/usr/include/libxml2 -I/usr/include/libxml2 -g -Wall -O2 -fno-strict-aliasing  -I/usr/include/freetype2    -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -I/usr/include/cairo    -fPIC -DPIC -fno-rtti -fno-exceptions   -MTobj-gnu/webcore_gdk_EditorClientGdk.o -MF`echo obj-gnu/webcore_gdk_EditorClientGdk.o | sed -e 's,\.o$,.d,'` -MD ../../platform/gdk/EditorClientGdk.cpp
../../platform/gdk/EditorClientGdk.cpp: In member function ‘virtual void WebCore::EditorClientGdk::handleKeypress(WebCore::KeyboardEvent*)’:
../../platform/gdk/EditorClientGdk.cpp:246: error: no matching function for call to ‘WebCore::Editor::insertText(WebCore::String, bool, WebCore::KeyboardEvent*&)’
../../editing/Editor.h:144: note: candidates are: bool WebCore::Editor::insertText(const WebCore::String&, WebCore::Event*)
make: *** [obj-gnu/webcore_gdk_EditorClientGdk.o] Error 1

g++ -c -o obj-gnu/webcore_gdk_ImageGdk.o -I../../../JavaScriptCore -I../.. -I../../bindings/js -I../../bridge -I../../css -I../../DerivedSources/WebCore -I../../dom -I../../editing -I../../ForwardingHeaders/kjs -I../../history -I../../html -I../../include -I../../loader -I../../loader/gdk -I../../loader/icon -I../../page -I../../platform -I../../platform/graphics -I../../platform/graphics/gdk -I../../platform/image-decoders -I../../platform/image-decoders/bmp -I../../platform/image-decoders/gif -I../../platform/image-decoders/ico -I../../platform/image-decoders/jpeg -I../../platform/image-decoders/png -I../../platform/image-decoders/xbm -I../../platform/image-decoders/zlib -I../../platform/network -I../../platform/network/gdk -I../../rendering -I../../xml -DENABLE_XSLT=1 -DLINUX -DUSE_CONSERVATIVE_GC=0 -DHAVE_FUNC_ISNAN -D_THREAD_SAFE -pthread -g -I../../platform/gdk -I../../platform/network/gdk -DBUILDING_GDK__ -DBUILDING_CAIRO__ -Iplatform/gdk -Iplatform/graphics/cairo -DENABLE_XPATH -I/usr/include/libxml2 -I/usr/include/libxml2 -g -Wall -O2 -fno-strict-aliasing  -I/usr/include/freetype2    -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -I/usr/include/cairo    -fPIC -DPIC -fno-rtti -fno-exceptions   -MTobj-gnu/webcore_gdk_ImageGdk.o -MF`echo obj-gnu/webcore_gdk_ImageGdk.o | sed -e 's,\.o$,.d,'` -MD ../../platform/graphics/gdk/ImageGdk.cpp
../../platform/graphics/gdk/ImageGdk.cpp: In static member function ‘static WebCore::Image* WebCore::Image::loadPlatformResource(const char*)’:
../../platform/graphics/gdk/ImageGdk.cpp:50: error: ‘class WebCore::BitmapImage’ has no member named ‘setNativeData’
make: *** [obj-gnu/webcore_gdk_ImageGdk.o] Error 1

g++ -c -o obj-gnu/webcore_gdk_ImageSourceCairo.o -I../../../JavaScriptCore -I../.. -I../../bindings/js -I../../bridge -I../../css -I../../DerivedSources/WebCore -I../../dom -I../../editing -I../../ForwardingHeaders/kjs -I../../history -I../../html -I../../include -I../../loader -I../../loader/gdk -I../../loader/icon -I../../page -I../../platform -I../../platform/graphics -I../../platform/graphics/gdk -I../../platform/image-decoders -I../../platform/image-decoders/bmp -I../../platform/image-decoders/gif -I../../platform/image-decoders/ico -I../../platform/image-decoders/jpeg -I../../platform/image-decoders/png -I../../platform/image-decoders/xbm -I../../platform/image-decoders/zlib -I../../platform/network -I../../platform/network/gdk -I../../rendering -I../../xml -DENABLE_XSLT=1 -DLINUX -DUSE_CONSERVATIVE_GC=0 -DHAVE_FUNC_ISNAN -D_THREAD_SAFE -pthread -g -I../../platform/gdk -I../../platform/network/gdk -DBUILDING_GDK__ -DBUILDING_CAIRO__ -Iplatform/gdk -Iplatform/graphics/cairo -DENABLE_XPATH -I/usr/include/libxml2 -I/usr/include/libxml2 -g -Wall -O2 -fno-strict-aliasing  -I/usr/include/freetype2    -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -I/usr/include/cairo    -fPIC -DPIC -fno-rtti -fno-exceptions   -MTobj-gnu/webcore_gdk_ImageSourceCairo.o -MF`echo obj-gnu/webcore_gdk_ImageSourceCairo.o | sed -e 's,\.o$,.d,'` -MD ../../platform/graphics/cairo/ImageSourceCairo.cpp
../../platform/graphics/cairo/ImageSourceCairo.cpp:107: error: prototype for ‘void WebCore::ImageSource::setData(const WTF::Vector<char, 0u>*, bool)’ does not match any in class ‘WebCore::ImageSource’
../../platform/graphics/ImageSource.h:73: error: candidate is: void WebCore::ImageSource::setData(WebCore::SharedBuffer*, bool)
make: *** [obj-gnu/webcore_gdk_ImageSourceCairo.o] Error 1

[Shrikant Gangoda]

Created attachment 13649 [details]
gdk build fix

modified EditorClientGDk.cpp , ImageGdk.cpp and ImageSourceCairo.cpp to fix the build.

[Shrikant Gangoda]

Created attachment 13657 [details]
gdklauncher build fix

patch to resolve below compilation error in gdklauncher.

g++ -c -o gdklauncher_main.o -DAPPLE_CHANGES=1 -DUSE_CONSERVATIVE_GC=0 -DENABLE_XSLT=1 -DHAVE_FUNC_ISNAN -I../../JavaScriptCore -I../../WebCore -I../../WebCore/DerivedSources/WebCore -I../../WebCore/bindings/js -I../../WebCore/bridge -I../../WebCore/css -I../../WebCore/dom -I../../WebCore/editing -I../../WebCore/history -I../../WebCore/html -I../../WebCore/include -I../../WebCore/loader -I../../WebCore/loader/gdk -I../../WebCore/page -I../../WebCore/page/gdk -I../../WebCore/platform -I../../WebCore/platform/gdk -I../../WebCore/platform/graphics/cairo -I../../WebCore/platform/graphics -I../../WebCore/platform/image-decoders/gif -I../../WebCore/platform/image-decoders/jpeg -I../../WebCore/platform/image-decoders/png -I../../WebCore/platform/image-decoders/zlib -I../../WebCore/platform/image-decoders -I../../WebCore/platform/network -I../../WebCore/platform/network/gdk -I../../WebCore/rendering -I../../WebCore/xml -D_THREAD_SAFE -pthread -DBUILDING_GDK__ -DBUILDING_CAIRO__ -g -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/include/freetype2     -fPIC -DPIC -fno-rtti -fno-exceptions   -MTgdklauncher_main.o -MF`echo gdklauncher_main.o | sed -e 's,\.o$,.d,'` -MD main.cpp
main.cpp: In function ‘int main(int, char**)’:
main.cpp:196: error: cannot allocate an object of abstract type ‘WebCore::FrameLoaderClientGdk’
../../WebCore/loader/gdk/FrameLoaderClientGdk.h:40: note:   because the following virtual functions are pure within ‘WebCore::FrameLoaderClientGdk’:
../../WebCore/loader/FrameLoaderClient.h:153: note:     virtual WebCore::ResourceError WebCore::FrameLoaderClient::blockedError(const WebCore::ResourceRequest&)

[Mark Rowe (bdash)]

Landed in r20234.  Please be wary of using tabs for indentation.