Bug 13042 - Linux/gdk improvements
Summary: Linux/gdk improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-10 21:36 PST by Krzysztof Kowalczyk
Modified: 2007-03-11 18:23 PDT (History)
0 users

See Also:

Attachments
Linux\gdk improvements (4.46 KB, patch)
2007-03-10 21:38 PST, Krzysztof Kowalczyk 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kowalczyk 2007-03-10 21:36:29 PST 
Linux/gdk improvements
Comment 1 Krzysztof Kowalczyk 2007-03-10 21:38:01 PST 
Created attachment 13583 [details]
Linux\gdk improvements

Add forward/backward/quit menus to gdklauncher for easier testing. Make FrameLoader:goBackOrForwards() work on gdk.
Comment 2 Brady Eidson 2007-03-11 15:27:01 PDT 
Comment on attachment 13583 [details]
Linux\gdk improvements

+    notImplementedGdk(); // FIXME: possibly. Maybe implementation below is good enough.
+    return item != 0;

Probably good enough for now, I don't think you need the notImplementedGdk().
But maybe you should document it better for future enhancement.  IE - file a bug pending a future PolicyDelegate which would be the real "WebKit-way" of doing this  ;)

Otherwise, looks good!
Comment 3 Krzysztof Kowalczyk 2007-03-11 18:23:38 PDT 
landed in r20105. Removed notImplemented() and added better (?) comment.