Bug 13001 - Missing accessibility localized strings cause assertion failure
Summary: Missing accessibility localized strings cause assertion failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2007-03-07 04:57 PST by Andrew Wellington
Modified: 2007-03-07 18:06 PST (History)
0 users

See Also:


Attachments
Patch (2.94 KB, patch)
2007-03-07 04:59 PST, Andrew Wellington
darin: review+
Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2007-03-07 15:00 PST, Andrew Wellington
andrew: review-
Details | Formatted Diff | Diff
Patch (2.08 KB, patch)
2007-03-07 15:02 PST, Andrew Wellington
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wellington 2007-03-07 04:57:45 PST
A number of accessibility strings are missing from Localizable.strings.

This means some accessibility functions will cause an assertion failure in WebKit:
ASSERTION FAILED: could not find localizable string web area in bundle
result != notFound
(/Users/andrew/Documents/Coding/WebKit-svn/WebKit/Misc/WebLocalizableStrings.m:57 WebLocalizedString)

To trigger this:
1. Load a web page or image in WebKit (eg. http://webkit.org/ )
2. Open Accessibility Viewer from the Developer tools
3. Hold the mouse over the WebKit window
Comment 1 Andrew Wellington 2007-03-07 04:59:07 PST
Created attachment 13515 [details]
Patch
Comment 2 Darin Adler 2007-03-07 06:24:04 PST
Comment on attachment 13515 [details]
Patch

This should be taken care of by running the script update-webkit-localizable-strings. Is that how you did this?

r=me
Comment 3 Mark Rowe (bdash) 2007-03-07 06:49:55 PST
<rdar://problem/5045722>
Comment 4 Andrew Wellington 2007-03-07 15:00:06 PST
Created attachment 13532 [details]
Patch

*Sigh* I created the previous patch with genstrings even though I had one made with update-webkit-localizable-strings. This one is made with update-webkit-localizable-strings which is the same changes but in a different order :-)

Now to file a bug on the problem with svn-create-patch that made me confuse which patch I was using...
Comment 5 Andrew Wellington 2007-03-07 15:00:50 PST
Comment on attachment 13532 [details]
Patch

Ignore that one, wrong ChangeLog entry. I think I need coffee...
Comment 6 Andrew Wellington 2007-03-07 15:02:47 PST
Created attachment 13533 [details]
Patch

Now with ChangeLog done right
Comment 7 Darin Adler 2007-03-07 15:08:13 PST
Comment on attachment 13533 [details]
Patch

r=me
Comment 8 Mark Rowe (bdash) 2007-03-07 18:06:34 PST
Tim Hatcher took care of this in r20037.