Bug 12950 - Assertions.cpp should not #define macros that are already defined
Summary: Assertions.cpp should not #define macros that are already defined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: PC Windows XP
: P2 Normal
Assignee: Don Gibson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-02 15:40 PST by Don Gibson
Modified: 2007-03-04 17:46 PST (History)
0 users

See Also:


Attachments
patch (931 bytes, patch)
2007-03-02 16:14 PST, Don Gibson
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Gibson 2007-03-02 15:40:41 PST
WINVER and _WIN32_WINNT should only be #defined when they don't already exist.

Patch coming shortly.
Comment 1 Don Gibson 2007-03-02 16:14:28 PST
Created attachment 13456 [details]
patch

Pretty simple, really...
Comment 2 Nikolas Zimmermann 2007-03-04 03:46:20 PST
Comment on attachment 13456 [details]
patch

Please remove the tabs used in JavaScriptCore/ChangeLog. As it's a trivial patch: r=me.
Comment 3 David Kilzer (:ddkilzer) 2007-03-04 17:46:44 PST
Committed revision 19956.