Bug 12906 - REGRESSION: Canvas is pixelated when the page is opened in a background tab
Summary: REGRESSION: Canvas is pixelated when the page is opened in a background tab
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL: http://www.cocoablogs.com/
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2007-02-27 04:54 PST by mitz
Modified: 2007-02-27 10:13 PST (History)
0 users

See Also:


Attachments
Reduction (449 bytes, text/html)
2007-02-27 05:27 PST, mitz
no flags Details
Fall back on the main screen's scale factor if the view is not in a window (1.24 KB, patch)
2007-02-27 05:59 PST, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-02-27 04:54:04 PST
To reproduce:
Create a new tab and open the URL in that (foreground) tab. In Safari Preferences > Tabs, deselect "select new tabs as they are created", then open the URL in a background tab. After the page is finished loading in the background tab, switch to it.

Expected results:
The clock should render at 1:1 resolution in the background tab, just like in the foreground tab.

Actual results:
The clock is pixelated in the tab that loaded in the background (looks like 2:1).

Regression:
Yes, shipping WebKit renders at full resolution in both tabs.
Comment 1 mitz 2007-02-27 05:27:46 PST
Created attachment 13393 [details]
Reduction
Comment 2 mitz 2007-02-27 05:59:01 PST
Created attachment 13396 [details]
Fall back on the main screen's scale factor if the view is not in a window

The main screen's scale factor is just a better guess than the undefined result of sending a message to nil. Since canvas does not seem to support dynamic changes to this parameter (as might be necessary when the view moves from one window to another?), you're stuck with the guessed value.
Comment 3 Darin Adler 2007-02-27 06:29:09 PST
Comment on attachment 13396 [details]
Fall back on the main screen's scale factor if the view is not in a window

Looks like the right thing to do.

r=me
Comment 4 Alexey Proskuryakov 2007-02-27 10:13:40 PST
Committed revision 19887.