Bug 12901 – [S60] Browser ask permission for unsecure item load repeatedly

• Status: CLOSED
• Resolution: FIXED
• Component: WebKit Misc.

[Yinxiu Cai]

Load https://waplabdc.nokia-boston.com/browser/users/tmclean/LgImage.html
Note the two "unsecure items" warnings, one for each image
It is logical to expect only one such warning when loading a page with multiple unsecure items.

[Yinxiu Cai]

Created attachment 13399 [details]
TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure item load repeatedly

[Yinxiu Cai]

Bug id 12901 is for 3.2

[Yongjun Zhang]

Comment on attachment 13399 [details]
TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure item load repeatedly

I think the patch is incorrect:
1. maintaining iNonSecureItemShown in both CWebKitLoader and CHttpLoader is redundant.
2. add global flags in WebKitLoader for this purpose is generally not a good idea.
3. In CHttpLoader::CheckSecurityStatus, the patch only considered one senario when a secure page requests insecure subresources.  How about a insure page requests multiple secure sburesources. The ESecureItemInNonSecurePage   dialog will show up multiple times.

the patch is rejected based on abovementioned reasons.

[Yinxiu Cai]

Created attachment 13406 [details]
TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure item load repeatedly

Made change according to Yongjun's comment. Thanks a lot to Yongjun.

[Yongjun Zhang]

Comment on attachment 13406 [details]
TMCN-6Y9Q7A -- TRUE - Browser ask permission for unsecure item load repeatedly

Use the right comment in header file.
don't need to copy the result to error, just pass it right to iConfirmDialogShow should be fine.

[Yinxiu Cai]

Created attachment 13413 [details]
TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly

[Yongjun Zhang]

Comment on attachment 13413 [details]
TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly

r=me

[Bradley Morrison]

(In reply to comment #7)
> (From update of attachment 13413 [details] [edit])
> r=me
> 

landed on s60/trunk (r19916)

I'll assume from your earlier comment that this is not going into 3.1, so I'll set this to resolved.

[Krishna]

Verified and Closed.

[Yinxiu Cai]

Created attachment 13637 [details]
TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly For 3.1

12-Mar-2007 Linnalo: Valid for Maxi_0710 and S60_3_1_200710_RnD_rosetta. Could the fix be ported to 3.1 also? 
14-Mar2007 Yinxiu: So put to 3.1

[Yongjun Zhang]

Comment on attachment 13637 [details]
TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly For 3.1

r = me

[Yinxiu Cai]

Created attachment 13647 [details]
Fix armv5 urel build warning, so on

When put to 3.1, found armv5 urel build warning, so on. So this patch is to fix it.

[Yongjun Zhang]

Comment on attachment 13647 [details]
Fix armv5 urel build warning, so on

r=me

[Bradley Morrison]

(In reply to comment #11)
> (From update of attachment 13637 [details] [edit])
> r = me
> 

20238

[Yinxiu Cai]

Hi Brad, Thank you for put patch 13637 to 3.1. Could you please put patch 13647 to 3.2(ccb)? thanks a lot.

[Joel Parks]

re-purposing InTSW keyword for use by QtWebkit team