Bug 12864 - Crash due to NULL m_frame
Summary: Crash due to NULL m_frame
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-22 21:41 PST by Oscar Cwajbaum
Modified: 2009-03-16 01:04 PDT (History)
3 users (show)

See Also:


Attachments
Check for m_frame == NULL patch (1.03 KB, patch)
2007-02-22 21:42 PST, Oscar Cwajbaum
mjs: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oscar Cwajbaum 2007-02-22 21:41:31 PST
I saw a crash on my build in DocumentLoader::stopLoading() because m_frame was set to NULL. stopLoading() assumes that if m_committed is true, m_frame is not NULL, but this does not seem to be enforced elsewhere in the code. Therefore, I've put together the attached patch which adds a NULL check for m_frame.
Comment 1 Oscar Cwajbaum 2007-02-22 21:42:17 PST
Created attachment 13339 [details]
Check for m_frame == NULL patch
Comment 2 Maciej Stachowiak 2007-02-22 23:18:52 PST
Comment on attachment 13339 [details]
Check for m_frame == NULL patch

Looks like a good fix, but this patch needs a test case. r- for lack of test case.
Comment 3 Eric Seidel (no email) 2007-10-01 09:45:13 PDT
I'm not sure how useful this bug is.  Someone with CrashReporter access (apple employee) could check to see if this is a common crash point.  If it isn't, then we should probably just assume this has already been fixed by some other fix and close the bug.  Thanks for the report!
Comment 4 Robert Blaut 2008-03-16 11:36:37 PDT
(In reply to comment #3)
> I'm not sure how useful this bug is.  Someone with CrashReporter access (apple
> employee) could check to see if this is a common crash point.  If it isn't,
> then we should probably just assume this has already been fixed by some other
> fix and close the bug.  Thanks for the report!
> 
Any progress on this bug? What further action should be performed to proceed with this report?
Comment 5 Alexey Proskuryakov 2009-03-16 01:04:59 PDT
Frameless documents don't do loading, so such a crash would indicate a problem somewhere else. But it's likely that is has been fixed since the bug was filed.

Marking INVALID, since this could never be confirmed.