WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
12859
BackForwardList of capacity 1 has unlimited size
https://bugs.webkit.org/show_bug.cgi?id=12859
Summary
BackForwardList of capacity 1 has unlimited size
Dex Deacon
Reported
2007-02-22 15:02:33 PST
BackForwardList::addItem does not remove an entry if it is the current entry, so a capacity 1 list will grow forever.
Attachments
add a check for when capacity==1
(1.19 KB, patch)
2007-02-22 15:04 PST
,
Dex Deacon
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dex Deacon
Comment 1
2007-02-22 15:04:03 PST
Created
attachment 13330
[details]
add a check for when capacity==1
Darin Adler
Comment 2
2007-02-22 15:35:59 PST
Comment on
attachment 13330
[details]
add a check for when capacity==1 Please don't use tabs in your patches. If you do, we can't land them! It seems that with this fix, the "not using it" concept goes away entirely for capacity-1 lists. I guess that's OK. r=me
Alexey Proskuryakov
Comment 3
2007-02-27 10:58:25 PST
Committed revision 19889.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug