CLOSED FIXED 12816
[s60] Toolbar should be activated only on long keypress 
https://bugs.webkit.org/show_bug.cgi?id=12816
Summary [s60] Toolbar should be activated only on long keypress
Sriram
Reported 2007-02-19 14:19:27 PST
CR 102-5945
Attachments
3.1 patch for toolbar activation (4.24 KB, patch)
2007-02-19 14:22 PST, Sriram 		no flags
DetailsFormatted DiffDiff
3.1 Patch for toolbar (4.17 KB, patch)
2007-02-19 14:44 PST, Sriram 		zalan: review-
DetailsFormatted DiffDiff
3.1 Fix as an Engine feature (3.41 KB, patch)
2007-02-19 16:58 PST, Sriram 		bradley.morrison: review-
DetailsFormatted DiffDiff
3.1 patch for toolbar (4.24 KB, patch)
2007-02-23 15:03 PST, Sriram 		no flags
DetailsFormatted DiffDiff
3.1 Patch for toolbar long key press (5.11 KB, patch)
2007-02-23 15:36 PST, Sriram 		Sachin.Padma: review+
DetailsFormatted DiffDiff
Toolbar should be activated on long key press in 3.2 (3.99 KB, patch)
2007-04-19 14:28 PDT, Sriram 		Sachin.Padma: review-
DetailsFormatted DiffDiff
3.2 Toolbar long key press (5.08 KB, patch)
2007-04-30 10:34 PDT, Sriram 		Sachin.Padma: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Sriram
Comment 1 2007-02-19 14:22:46 PST
Created attachment 13251 [details] 3.1 patch for toolbar activation Please review task 14029 for browser ui changes
Sriram
Comment 2 2007-02-19 14:44:17 PST
Created attachment 13254 [details] 3.1 Patch for toolbar Please review code for task 14029 in Browser ui
zalan
Comment 3 2007-02-19 14:58:30 PST
Comment on attachment 13254 [details] 3.1 Patch for toolbar it moves toolbar click from client to host.
Sriram
Comment 4 2007-02-19 16:58:52 PST
Created attachment 13257 [details] 3.1 Fix as an Engine feature Please review this if toolbar activation is an engine feature
Sachin Padma
Comment 5 2007-02-23 07:13:59 PST
Comment on attachment 13257 [details] 3.1 Fix as an Engine feature r=me
Bradley Morrison
Comment 6 2007-02-23 10:34:30 PST
Comment on attachment 13257 [details] 3.1 Fix as an Engine feature The Boss Says No: r-
Sachin Padma
Comment 7 2007-02-23 10:35:03 PST
Comment on attachment 13257 [details] 3.1 Fix as an Engine feature Check either Enter key or move the activation inside the case for enter key
Sriram
Comment 8 2007-02-23 15:03:45 PST
Created attachment 13354 [details] 3.1 patch for toolbar
Sriram
Comment 9 2007-02-23 15:36:52 PST
Created attachment 13355 [details] 3.1 Patch for toolbar long key press
Sachin Padma
Comment 10 2007-02-28 11:31:28 PST
Comment on attachment 13355 [details] 3.1 Patch for toolbar long key press r=me
Bradley Morrison
Comment 11 2007-02-28 14:23:59 PST
(In reply to comment #10) > (From update of attachment 13355 [details] [edit]) > r=me > landed at r19913
Krishna
Comment 12 2007-03-04 17:20:53 PST
Closed.
Sriram
Comment 13 2007-04-19 14:28:46 PDT
Created attachment 14096 [details] Toolbar should be activated on long key press in 3.2
Sachin Padma
Comment 14 2007-04-30 08:02:39 PDT
Comment on attachment 14096 [details] Toolbar should be activated on long key press in 3.2 Please attach changelog.
Sriram
Comment 15 2007-04-30 10:34:57 PDT
Created attachment 14275 [details] 3.2 Toolbar long key press
Sachin Padma
Comment 16 2007-05-01 14:56:48 PDT
Comment on attachment 14275 [details] 3.2 Toolbar long key press r=me
Note You need to log in before you can comment on or make changes to this bug.