Summery: In Gmail>Compose, tabbing from To, to Subject, and then logically and most helpfully to body of the message doesn't work as it did in 419.3 Steps to reproduce: Go to Gmail>Compose Press tab (moves from To: to Subject) Press tab (moves from Subject to Send button) Whereas in 419.3 moves to main box to type in message
Stephen, I'm unable to reproduce this on a ToT debug build (r19707). Can you provide some more details about your configuration? Do you have the "Press Tab to highlight each item on a webpage" Safari preference turned on? What about universal keyboard access?
I can reproduce this. Mac OS X 10.4.8 PowerPC Safari 2.0.4 (419.3) WebKit r19727 Safari is not set to tab to every item on the page. Keyboard & Mouse System Preferences are set to tab to all controls This does not occur with WebKit 418.9.1, however Gmail serves it the basic compose field, whereas the ToT WebKit receives a rich text editor. The compose field on ToT is an iframe element, not a form textara element as in the release Safari's page.
Hi Adam, (In reply to comment #1) > Stephen, I'm unable to reproduce this on a ToT debug build (r19707). Can you > provide some more details about your configuration? Do you have the "Press Tab > to highlight each item on a webpage" Safari preference turned on? No I don't have this turned on > What about universal keyboard access? If you mean full keyboard access [in Keyboard and Mouse Prefs], then yes it is on for 'all controls'. Interestingly, if I switch this preference to 'text boxes and lists only' tabbing through Gmail>Compose Mail goes from to:, subject: and then google search at the top in Gmail (this appears to be another knock on effect from Safari's bad handling of the rich text box and tabbing - notice it works fine in plain text and also in FFX 2.0.0.1 which ever way the full keyboard access is set) Andrew - nice one for spotting about the rich text and plain text editor. So basically, I found the same: - In rich text tabbing doesn't work properly - Switch it to plain text it works fine I guess technically then this shouldn't be a regression issue as for Safari rich text is a new feature for composing in Gmail. Although it kind of is a regression since it breaks the way Safari properly handles the default way users will access Gmail>Compose Mail and then tabbing through it, which in WebKit 418.9.1 works fine
<rdar://problem/5028157>
Created attachment 13455 [details] Reduction I debugged this some and was able to come up with this reduction. The problem is that the Subject field and the buttons at the bottom have their tabIndex set to 1. The iframe (the message body) does not have a tabIndex attribute set, so it defaults to 0. Adam (and Geoff?) recently did a bunch of work with our tab order stuff, and the current implementation matches the HTML4 spec. This works in Firefox because Firefox has a lot of tab order bugs as compared with the spec. This could be fixed very easily from the GMail side by adding a tabIndex=1 attribute to the iframe. In fact, we may need to fix this bug that way. I'm not sure we will be willing to change our behavior since it appears to match the spec. (Though I will verify that it matches the spec first, of course.)
Here is the part of the spec that addresses tab order: http://www.w3.org/TR/html401/interact/forms.html#h-17.11.1 Our behavior is clearly correct. The one place that we diverge from the spec is that we support tabindex on more elements that the spec lists, including iframe, meaning that the GMail fix I suggested above does actually work. It looks like all browsers support tabindex on more elements than the spec indicates. Anyway, this seems like an evangelism issue after all.
This bug needs some Google-evangelism-love per Comment #5 and Comment #6.
Alrighty then, I'll take a look. Thanks for the detailed report.
Fix checked in on the main branch. It'll be a week or two before it hits production.
Thanks. I assume that will apply to both the US and UK and other versions of Gmail?
Antti tried this on 3/22 and said it was indeed fixed on the Google side.
Only on the US site. Please can Google update it for all other languages on Gmail as well? (In reply to comment #11) > Antti tried this on 3/22 and said it was indeed fixed on the Google side. >
(In reply to comment #12) > Only on the US site. Please can Google update it for all other languages on > Gmail as well? > Reclosing this bug since there is nothing more we can do on our end - it's entirely up to Google to decide what updates they release and when they choose to do so.