Bug 12800 - Some COMPILER(MSVC) blocks marked instead as PLATFORM(WIN)
Summary: Some COMPILER(MSVC) blocks marked instead as PLATFORM(WIN)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-17 20:03 PST by Kevin Ollivier
Modified: 2007-02-18 00:59 PST (History)
0 users

See Also:


Attachments
Changes PLATFORM(WIN) to COMPILER(MSVC) where appropriate. (2.17 KB, patch)
2007-02-17 20:04 PST, Kevin Ollivier
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Ollivier 2007-02-17 20:03:39 PST
If a platform/port other than Win32 is built using MSVC on Windows (e.g. the wx port), it currently won't compile unless WTF_PLATFORM_WIN is explicitly defined. (Which doesn't seem right to me.) After changing these blocks to check for COMPILER(MSVC) instead, I am able to compile JSCore and WebCore using MSVC without defining WTF_PLATFORM_WIN.
Comment 1 Kevin Ollivier 2007-02-17 20:04:59 PST
Created attachment 13217 [details]
Changes PLATFORM(WIN) to COMPILER(MSVC) where appropriate.
Comment 2 Adam Roben (:aroben) 2007-02-17 20:08:49 PST
Comment on attachment 13217 [details]
Changes PLATFORM(WIN) to COMPILER(MSVC) where appropriate.

Looks good. r=me!
Comment 3 Alexey Proskuryakov 2007-02-18 00:59:57 PST
Committed revision 19688.