curl networking improvements for gdk build
Created attachment 13195 [details] curl networking improvements Curl networking improvements, enable entering text into text field on gdk, comment-out chatty messages that clutter output.
Comment on attachment 13195 [details] curl networking improvements + free((void*)m_url); Is this cast to void* really necessary? + for (;;) { I believe while (true) is a bit more inline with our coding style. + void setupPOST(ResourceHandle* job); + void setupPUT(ResourceHandle* job); You should remove the parameter names here. I don't know much about curl, but this code looks sane. r=me.
Comment on attachment 13195 [details] curl networking improvements + struct curl_slist *m_customHeaders; WebKit style guide is Type* ident so "struct curl_slist* m_customHeaders" * in the wrong place again: + ResourceHandle *job; + ResourceHandleInternal *d = job->getInternal(); + char *url = 0; + struct curl_slist *headers = 0; + const char *header = headerString.latin1().data(); + char * m_cookieJarFileName; // FIXME: never freed Otherwise looks reasonable -- but i cannot vouch for correctness, i don't know gdk at all.
Created attachment 13209 [details] updated per review comments Fixed all style issues pointed out in the review. Also added fixes for FrameLoaderClientGdk. free((void*)) and for (;;) were because there is a compiler that complains about free() without case and while (true) loop, but I just checked and this compiler isn't gcc event with -Wall -pedantic so I changed those.
Comment on attachment 13209 [details] updated per review comments r=me. Thanks for fixing those few issues!
commited as r19676 and r19677