RESOLVED FIXED 12777
REGRESSION (r18574): User profile pages display incorrectly at ebay.ca 
https://bugs.webkit.org/show_bug.cgi?id=12777
Summary REGRESSION (r18574): User profile pages display incorrectly at ebay.ca
crastinator
Reported 2007-02-14 23:50:44 PST
Running webkit R19630. Any user profile page (the ones that display feedback) display incorrectly. Tried this on several user pages and I get the same thing. This seems to apply only to the .ca version of ebay.
Attachments
Partial reduction (745 bytes, text/html)
2007-02-15 04:32 PST, mitz 		no flags
Details
Fix table layout bug (44.82 KB, patch)
2007-02-15 06:56 PST, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2007-02-15 04:32:14 PST
Created attachment 13183 [details] Partial reduction The regression happened in r18574 (fix for bug 5164). Changing the percentScaleFactor in Length.h to 1 fixes the bug and this reduction, making me think that the bug has to do with one of the FIXMEs in AutoTableLayout.cpp.
mitz
Comment 2 2007-02-15 06:56:10 PST
Created attachment 13184 [details] Fix table layout bug The actual bug predates r18574 and fixing it gives better results in two existing tests. The reason for the regression is that the higher accuracy made it happen even in this bug's particular case (you can change the yellow cell's width in the reduction from 4 to 20 to get a case that fails in pre-r18574 builds).
David Kilzer (:ddkilzer)
Comment 3 2007-02-15 08:30:23 PST
(In reply to comment #2) > Created an attachment (id=13184) [edit] > Fix table layout bug The ChangeLog says that tables/mozilla_expected_failures/core/col_span2.html is "fixed", so should it move out of the mozilla_expected_failures directory?
mitz
Comment 4 2007-02-15 08:34:29 PST
(In reply to comment #3) > The ChangeLog says that tables/mozilla_expected_failures/core/col_span2.html is > "fixed", so should it move out of the mozilla_expected_failures directory? > That is a long test with many individual cases. In some of them WebKit's layout still don't match Firefox's, so I didn't want to move it. Perhaps a more appropriate phrasing for the change log would be "Covered by existing layout tests:".
Darin Adler
Comment 5 2007-02-15 09:46:33 PST
Comment on attachment 13184 [details] Fix table layout bug r=me
Sam Weinig
Comment 6 2007-02-15 10:57:04 PST
Landed in r19641.
Note You need to log in before you can comment on or make changes to this bug.