Bug 12611 – [S60] Crash when pcre stack overflows

• Status: CLOSED
• Resolution: FIXED
• Component: JavaScriptCore

[Pat]

Browser crashes when accessing the sites:
fi.map24.com and enviro.fi.

The JavaScriptCore/pcre has a stack overflow that causes a crash.

[Pat]

Created attachment 12936 [details]
Patch for pcre crash, when stack overflow

[Pat]

For 3.0 and 3.1 Approved TSW ID: TJPI-6XQJWP
For 3.1 Approved TSW ID: ALAA-6XSF7U

This fix will stop processing the pcre regexp when we reach a limit on the depth of recursion in the method match().  This will prevent us from reaching a stack overflow, but will diminish the functionality of the page, since the javascript is not parsed.

This solution is for a small memory device and these two web sites with abnormally huge javascript regexp requirements.  Other pages are working as designed. 

[Yongjun Zhang]

Comment on attachment 12936 [details]
Patch for pcre crash, when stack overflow

remove debug comments.

[Pat]

Created attachment 12938 [details]
2nd Patch for crash

Comments and commented out debug statements removed

[Yongjun Zhang]

Comment on attachment 12938 [details]
2nd Patch for crash

r=me

[Bradley Morrison]

(In reply to comment #5)
> (From update of attachment 12938 [details] [edit])
> r=me
> 

landed - r19430. Keeping this open, should it go into trunk? If not,please close.

[Bradley Morrison]

landed on s60/trunk - r19440. resolved.

[Krishna]

Verified and Closed.

[Joel Parks]

re-purposing InTSW keyword for use by QtWebkit team