Bug 12521 - CSS3: Support values 'start' and 'end' for text-align property
Summary: CSS3: Support values 'start' and 'end' for text-align property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nicholas Shanks
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-31 20:36 PST by Nicholas Shanks
Modified: 2007-10-02 14:41 PDT (History)
0 users

See Also:

Attachments
patch (4.50 KB, patch)
2007-01-31 20:37 PST, Nicholas Shanks 		no flags Details | Formatted Diff | Diff
replace case a...b with enumerated cases per hyatt's request (4.73 KB, patch)
2007-01-31 20:57 PST, Nicholas Shanks 		no flags Details | Formatted Diff | Diff
removed BOM and tabs from test case (4.76 KB, patch)
2007-02-01 07:22 PST, Nicholas Shanks 		darin: review-
Details | Formatted Diff | Diff
attempt number 4 (4.62 KB, patch)
2007-02-01 13:56 PST, Nicholas Shanks 		hyatt: review-
Details | Formatted Diff | Diff
now all fixed and stuff (16.51 KB, patch)
2007-10-01 13:26 PDT, Eric Seidel (no email) 		hyatt: review+
Details | Formatted Diff | Diff
even better fixing after hyatt's comments (ready to land) (16.51 KB, patch)
2007-10-01 13:44 PDT, Eric Seidel (no email) 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas Shanks 2007-01-31 20:36:43 PST 
Patch attached
Comment 1 Nicholas Shanks 2007-01-31 20:37:46 PST 
Created attachment 12844 [details]
patch
Comment 2 Dave Hyatt 2007-01-31 20:47:33 PST 
Comment on attachment 12844 [details]
patch

You can't check the style while resolution is in progress.  The direction has not been determined yet.
Comment 3 Dave Hyatt 2007-01-31 20:48:23 PST 
Comment on attachment 12844 [details]
patch

Oh, oops.  Never mind.  I forgot that I hacked direction to be one of the properties examined early.
Comment 4 Nicholas Shanks 2007-01-31 20:57:56 PST 
Created attachment 12846 [details]
replace case a...b with enumerated cases per hyatt's request
Comment 5 Nicholas Shanks 2007-02-01 07:22:08 PST 
Created attachment 12855 [details]
removed BOM and tabs from test case
Comment 6 Darin Adler 2007-02-01 07:42:21 PST 
Comment on attachment 12855 [details]
removed BOM and tabs from test case

The test contains a call to dumpAsText -- I don't understand why because I don't see how a plain-text dump would demonstrate whether the bug is fixed or not.

Further, the patch contains a render tree dump in the expected.txt, not plain text. There's no pixel test result: expected.checksum or expected.png.

If this is a plain-text test, then it needs a plain-text result. If not, then it should not have code saying dumpAsText and it needs a pixel result.
Comment 7 Nicholas Shanks 2007-02-01 13:56:59 PST 
Created attachment 12860 [details]
attempt number 4

you'll have to blame bdash: my original patch didn't have that script but he told me to put it in there! I don't know what it's for.
Comment 8 Eric Seidel (no email) 2007-10-01 09:25:45 PDT 
Comment on attachment 12860 [details]
attempt number 4

I didn't see any serious complaints in the bug about the previous patch.  I believe this one was meant to be marked for review.  The patch looks fine to me.  But lets get a second opinion.
Comment 9 Dave Hyatt 2007-10-01 12:48:32 PDT 
Comment on attachment 12860 [details]
attempt number 4

Change the switch statement to just be an if/else block. if (start) ... else if (end) ... and then do the assignment of the property.
Comment 10 Eric Seidel (no email) 2007-10-01 13:26:55 PDT 
Created attachment 16488 [details]
now all fixed and stuff
Comment 11 Dave Hyatt 2007-10-01 13:28:40 PDT 
Comment on attachment 16488 [details]
now all fixed and stuff

r=me
Comment 12 Eric Seidel (no email) 2007-10-01 13:44:37 PDT 
Created attachment 16489 [details]
even better fixing after hyatt's comments (ready to land)
Comment 13 Eric Seidel (no email) 2007-10-01 13:45:02 PDT 
Comment on attachment 16489 [details]
even better fixing after hyatt's comments (ready to land)

marking this as reviewed (hyatt did so already), as it's ready to land.
Comment 14 Eric Seidel (no email) 2007-10-02 14:41:54 PDT 
Landed on feature-branch as r25939.