Bug 12507 - Hebrew form data can be uploaded with wrong encoding name (visual vs. logical)
Summary: Hebrew form data can be uploaded with wrong encoding name (visual vs. logical)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2007-01-31 09:51 PST by Darin Adler
Modified: 2007-01-31 20:53 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2007-01-31 09:51:17 PST 
<GMT25-Aug-2003 01:50:10GMT> Darin Adler:
The code that maps a QTextCodec back to an encoding name doesn't take the flags into account. It should. The effect of this is that you can end up with the name of a Hebrew visual encoding when you meant logical or vice versa.

<GMT25-Aug-2003 01:52:44GMT> Darin Adler:
The fix to this is relatively simple; just take the flags into account when doing the reverse mapping. An even better fix would be to change things so that we use the encoding name from the incoming side on the outgoing side; the QTextCodec could remember the name it was created with. Then we could remove the reverse mapping altogether.

I've attached a first cut at a patch.

<rdar://problem/3391826>
Comment 1 Alexey Proskuryakov 2007-01-31 11:17:01 PST 
TextEncoding now keeps the original charset name - is this issue still valid?
Comment 2 Darin Adler 2007-01-31 11:53:19 PST 
(In reply to comment #1)
> TextEncoding now keeps the original charset name - is this issue still valid?

Probably not! Lets see if we can test it to be sure.
Comment 3 Darin Adler 2007-01-31 20:53:09 PST 
OK, agreed that this is fixed.