WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
12507
Hebrew form data can be uploaded with wrong encoding name (visual vs. logical)
https://bugs.webkit.org/show_bug.cgi?id=12507
Summary
Hebrew form data can be uploaded with wrong encoding name (visual vs. logical)
Darin Adler
Reported
2007-01-31 09:51:17 PST
<GMT25-Aug-2003 01:50:10GMT> Darin Adler: The code that maps a QTextCodec back to an encoding name doesn't take the flags into account. It should. The effect of this is that you can end up with the name of a Hebrew visual encoding when you meant logical or vice versa. <GMT25-Aug-2003 01:52:44GMT> Darin Adler: The fix to this is relatively simple; just take the flags into account when doing the reverse mapping. An even better fix would be to change things so that we use the encoding name from the incoming side on the outgoing side; the QTextCodec could remember the name it was created with. Then we could remove the reverse mapping altogether. I've attached a first cut at a patch. <
rdar://problem/3391826
>
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2007-01-31 11:17:01 PST
TextEncoding now keeps the original charset name - is this issue still valid?
Darin Adler
Comment 2
2007-01-31 11:53:19 PST
(In reply to
comment #1
)
> TextEncoding now keeps the original charset name - is this issue still valid?
Probably not! Lets see if we can test it to be sure.
Darin Adler
Comment 3
2007-01-31 20:53:09 PST
OK, agreed that this is fixed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug