WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
12470
svn-create-patch creates duplicate patches for files within an added/modified directory
https://bugs.webkit.org/show_bug.cgi?id=12470
Summary
svn-create-patch creates duplicate patches for files within an added/modified...
David Kilzer (:ddkilzer)
Reported
2007-01-29 22:51:24 PST
While creating the latest patch for
Bug 11882
, I noticed that I kept getting duplicate copies of all of the new webarchive layout tests and their results in the patch. The problem was that svn-create-patch saw "LayoutTests/webarchive" as a modified "file", and ran a diff on it. The correct solution (for now) is to ignore modified directories when creating a patch. I have a patch to fix this.
Attachments
Patch v1
(1.17 KB, patch)
2007-01-29 22:53 PST
,
David Kilzer (:ddkilzer)
mrowe
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2007-01-29 22:53:49 PST
Created
attachment 12777
[details]
Patch v1 Proposed fix.
Mark Rowe (bdash)
Comment 2
2007-01-30 04:49:07 PST
Comment on
attachment 12777
[details]
Patch v1 r=me
David Kilzer (:ddkilzer)
Comment 3
2007-01-30 06:42:07 PST
Committed revision 19256.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug