Bug 12465 - REGRESSION: favicon.ico looked for on port 0
Summary: REGRESSION: favicon.ico looked for on port 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Brady Eidson
URL: http://www.google.com
Keywords: EasyFix, Regression
Depends on:
Blocks:
 
Reported: 2007-01-29 12:39 PST by Alexey Proskuryakov
Modified: 2007-01-29 14:20 PST (History)
3 users (show)

See Also:

Attachments
Patch (975 bytes, patch)
2007-01-29 14:11 PST, Brady Eidson 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2007-01-29 12:39:16 PST 
After the fix for bug 11085, most favicons are looked for at port 0.

Steps to reproduce: open www.google.com, open Activity window, check the entry for favicon.ico.
Comment 1 Maciej Stachowiak 2007-01-29 14:01:10 PST 
We should special-case port number of 0 as no port, since a URL will never validly have a portn number of 0.
Comment 2 Brady Eidson 2007-01-29 14:11:14 PST 
Created attachment 12757 [details]
Patch
Comment 3 Oliver Hunt 2007-01-29 14:15:56 PST 
Comment on attachment 12757 [details]
Patch

indentation appears to be borken, but otherwise r=me
Comment 4 Brady Eidson 2007-01-29 14:20:31 PST 
r19235