Bug 12441 – SVG text selection should restrict auto-select on double and triple click

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Rob Buis]

The current way of auto-selecting when double or triple clicking svg elements makes no sense for
objects other than pure text.

[Rob Buis]

Created attachment 12711 [details]
First attempt

This patch should do the trick. I played around with -webkit-user-select in svg.css, but that doesnt seem to do what we want here.
Cheers,

Rob.

[Rob Buis]

*** Bug 11684 has been marked as a duplicate of this bug. ***

[Darin Adler]

Comment on attachment 12711 [details]
First attempt

I'd like this to be done without adding ifdef SVG_SUPPORT to these functions, even if that means adding a new virtual function to RenderObject.

[Rob Buis]

Created attachment 12735 [details]
without SVG_SUPPORT usage

This patches uses a new virtual method to check whether the render object can be part of a double or triple-click selection.
Cheers,

Rob.

[Darin Adler]

Comment on attachment 12735 [details]
without SVG_SUPPORT usage

Looks great!

Two problems:

1) the change to EventHandler.cpp seems to be missing from this patch although it's mentioned in the change log

2) the declaration of canMultiSelect in RenderSVGImage seems to be indented incorrectly

[Darin Adler]

I also suggest making the comment say just "object" instead of "render object".

Finally, this *could* be done by introducing a special value for -webkit-user-select that means "single click only". I'm not sure that would be better, but it might be worth considering.

[Eric Seidel (no email)]

Looks like this mostly-done patch has been forgotten.

[Nikolas Zimmermann]

Rob, is this still valid?

[Rob Buis]

Hello Niko,

(In reply to comment #8)
> Rob, is this still valid?

I forgot the original behaviour, but right now selection behaves the same for svg text as
for html text, which I suppose can be explained by your recent text patch(es). So I think this
can be closed.
Cheers,

Rob.

[Rob Buis]

Likely fixed by WldFox recent text work.