Bug 12422 - [S60] Disabling Java/ECMA script on www.viamichelin.com crashes Browser
Summary: [S60] Disabling Java/ECMA script on www.viamichelin.com crashes Browser
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 420+
Hardware: PC S60 3rd edition
: P2 Critical
Assignee: Nobody
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2007-01-26 11:50 PST by Hong Zhao
Modified: 2011-03-21 11:53 PDT (History)
0 users

See Also:


Attachments
Fix the crash of disable JavaScript settings while the page is open. (1.18 KB, patch)
2007-01-26 12:49 PST, Hong Zhao
zalan: review-
Details | Formatted Diff | Diff
Fix the crash in disable JavaScript settings while the page is open in 3.1. (1.22 KB, patch)
2007-01-26 12:53 PST, Hong Zhao
zalan: review-
Details | Formatted Diff | Diff
Fix the crash of disable JavaScript settings while the page is open. (1.72 KB, patch)
2007-01-29 07:26 PST, Hong Zhao
zalan: review+
Details | Formatted Diff | Diff
Fix the crash of disable JavaScript settings while the page is open in 3.1m. (1.72 KB, patch)
2007-01-29 07:34 PST, Hong Zhao
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hong Zhao 2007-01-26 11:50:53 PST
TSW BugID: MHAE-6XQJ5V

- Use case:
Browsing on http://www.viamichelin.com (popular free site with maps & navigation instructions to Europe) 

- Steps to reproduce:
1. Load www.viamichelin.com
2. Go to Browser settings -> General -> set Java/ECMA script to Disabled

- Actual outcome:
Browser crashes when Java/ECMA script is disabled.

- Expected outcome:
Java/ECMA script can disabled without a crash.
Comment 1 Hong Zhao 2007-01-26 12:49:59 PST
Created attachment 12692 [details]
Fix the crash of disable JavaScript settings while the page is open.
Comment 2 Hong Zhao 2007-01-26 12:53:01 PST
Created attachment 12693 [details]
Fix the crash in disable JavaScript settings while the page is open in 3.1.
Comment 3 zalan 2007-01-28 20:01:08 PST
Comment on attachment 12692 [details]
Fix the crash of disable JavaScript settings while the page is open.

fix looks great but you dont have to declare the proxy variable unless you really use it.
so either 
if (!KJSProxy::proxy(window->m_part))
   {
   return;
   }
or

KJSProxy *proxy = KJSProxy::proxy(window->m_part);
if (!proxy)
   {
   return;
   }
ScriptInterpreter *interpreter = static_cast<ScriptInterpreter *>(proxy->interpreter());
Comment 4 zalan 2007-01-28 20:02:10 PST
Comment on attachment 12693 [details]
Fix the crash in disable JavaScript settings while the page is open in 3.1.

same here
Comment 5 Hong Zhao 2007-01-29 07:26:27 PST
Created attachment 12739 [details]
Fix the crash of disable JavaScript settings while the page is open.
Comment 6 Hong Zhao 2007-01-29 07:34:34 PST
Created attachment 12740 [details]
Fix the crash of disable JavaScript settings while the page is open in 3.1m.
Comment 7 zalan 2007-01-29 18:28:42 PST
Comment on attachment 12739 [details]
Fix the crash of disable JavaScript settings while the page is open.

r=me
Comment 8 zalan 2007-01-29 18:29:15 PST
Comment on attachment 12740 [details]
Fix the crash of disable JavaScript settings while the page is open in 3.1m.

r=me
Comment 9 zalan 2007-01-29 18:31:09 PST
3.1->r19240
3.2->r19241
Comment 10 Krishna 2007-02-09 13:30:39 PST
Verified and Closed.
Comment 11 Joel Parks 2011-03-21 11:53:02 PDT
re-purposing InTSW keyword for use by QtWebkit team