TSW BugID: MHAE-6XQJ5V - Use case: Browsing on http://www.viamichelin.com (popular free site with maps & navigation instructions to Europe) - Steps to reproduce: 1. Load www.viamichelin.com 2. Go to Browser settings -> General -> set Java/ECMA script to Disabled - Actual outcome: Browser crashes when Java/ECMA script is disabled. - Expected outcome: Java/ECMA script can disabled without a crash.
Created attachment 12692 [details] Fix the crash of disable JavaScript settings while the page is open.
Created attachment 12693 [details] Fix the crash in disable JavaScript settings while the page is open in 3.1.
Comment on attachment 12692 [details] Fix the crash of disable JavaScript settings while the page is open. fix looks great but you dont have to declare the proxy variable unless you really use it. so either if (!KJSProxy::proxy(window->m_part)) { return; } or KJSProxy *proxy = KJSProxy::proxy(window->m_part); if (!proxy) { return; } ScriptInterpreter *interpreter = static_cast<ScriptInterpreter *>(proxy->interpreter());
Comment on attachment 12693 [details] Fix the crash in disable JavaScript settings while the page is open in 3.1. same here
Created attachment 12739 [details] Fix the crash of disable JavaScript settings while the page is open.
Created attachment 12740 [details] Fix the crash of disable JavaScript settings while the page is open in 3.1m.
Comment on attachment 12739 [details] Fix the crash of disable JavaScript settings while the page is open. r=me
Comment on attachment 12740 [details] Fix the crash of disable JavaScript settings while the page is open in 3.1m. r=me
3.1->r19240 3.2->r19241
Verified and Closed.
re-purposing InTSW keyword for use by QtWebkit team