Bug 12394 - Cleanup RenderBox
Summary: Cleanup RenderBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-24 11:58 PST by Sam Weinig
Modified: 2007-01-24 13:49 PST (History)
0 users

See Also:


Attachments
patch (67.48 KB, patch)
2007-01-24 12:01 PST, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2007-01-24 11:58:51 PST
Patch forthcoming!
Comment 1 Sam Weinig 2007-01-24 12:01:12 PST
Created attachment 12644 [details]
patch
Comment 2 mitz 2007-01-24 12:53:27 PST
Comment on attachment 12644 [details]
patch

-    if (isFloating() || (isCompact() && isInline()) || 
+    if (isFloating() || (isCompact() && isInline()) ||
         (isInlineBlockOrInlineTable() && !isHTMLMarquee()))

In other places in this patch you moved the operator after the line break. Same here:

-            m_height = max(m_height, visHeight - 
-                            (margins + parent()->marginTop() + parent()->marginBottom() + 
+            m_height = max(m_height, visHeight -
+                            (margins + parent()->marginTop() + parent()->marginBottom() +

and here:

+        for (; !cb->isRenderView() && !cb->isBody() && !cb->isTableCell() && !cb->isPositioned() &&
                 cb->style()->height().isAuto(); cb = cb->containingBlock());

r=me
Comment 3 Sam Weinig 2007-01-24 13:49:16 PST
Landed in r19080.