WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
12394
Cleanup RenderBox
https://bugs.webkit.org/show_bug.cgi?id=12394
Summary
Cleanup RenderBox
Sam Weinig
Reported
2007-01-24 11:58:51 PST
Patch forthcoming!
Attachments
patch
(67.48 KB, patch)
2007-01-24 12:01 PST
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2007-01-24 12:01:12 PST
Created
attachment 12644
[details]
patch
mitz
Comment 2
2007-01-24 12:53:27 PST
Comment on
attachment 12644
[details]
patch - if (isFloating() || (isCompact() && isInline()) || + if (isFloating() || (isCompact() && isInline()) || (isInlineBlockOrInlineTable() && !isHTMLMarquee())) In other places in this patch you moved the operator after the line break. Same here: - m_height = max(m_height, visHeight - - (margins + parent()->marginTop() + parent()->marginBottom() + + m_height = max(m_height, visHeight - + (margins + parent()->marginTop() + parent()->marginBottom() + and here: + for (; !cb->isRenderView() && !cb->isBody() && !cb->isTableCell() && !cb->isPositioned() && cb->style()->height().isAuto(); cb = cb->containingBlock()); r=me
Sam Weinig
Comment 3
2007-01-24 13:49:16 PST
Landed in
r19080
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug