Bug 12380 - SVG resources (masks, markers, clipPaths) have updating/dynamic creation problems.
Summary: SVG resources (masks, markers, clipPaths) have updating/dynamic creation prob...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-23 05:26 PST by Nikolas Zimmermann
Modified: 2007-01-23 12:22 PST (History)
2 users (show)

See Also:


Attachments
Initial patch. (42.68 KB, patch)
2007-01-23 05:31 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
LayoutTests (200.53 KB, patch)
2007-01-23 05:32 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Updated patch. (244.70 KB, patch)
2007-01-23 11:42 PST, Nikolas Zimmermann
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2007-01-23 05:26:05 PST
Patterns/Gradients already use the new "isPendingResource" & friends concept to keep track of any not-yet available resource - when it appears they update nicely. All other resources need to work in the same way. Attaching patch soon.
Comment 1 Nikolas Zimmermann 2007-01-23 05:31:06 PST
Created attachment 12622 [details]
Initial patch.

Patch fixing all known resource updating/invalidation/creation bugs. The 16 new LayoutTests will be in a seperated patch - otherwhise it's waaay too big.
Comment 2 Nikolas Zimmermann 2007-01-23 05:32:24 PST
Created attachment 12623 [details]
LayoutTests

I left out the .png's otherwhise it gets too big.
Comment 3 Nikolas Zimmermann 2007-01-23 11:42:47 PST
Created attachment 12632 [details]
Updated patch.

New patch fixing the issues Sam mentioned via IRC. No new regressions in pixel tests. One existing testcase works again - 16 added.
Comment 4 Nikolas Zimmermann 2007-01-23 12:22:54 PST
Landed in r19050.