WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
12374
Performance optimization to patch for
Bug 10773
https://bugs.webkit.org/show_bug.cgi?id=12374
Summary
Performance optimization to patch for Bug 10773
Sanjay Madhav (chmmravatar)
Reported
2007-01-22 21:52:31 PST
Simple optimization: don't bother calling markDOMNodesForDocument if the JSDocument was already marked.
Attachments
patch as described
(1.03 KB, patch)
2007-01-22 21:53 PST
,
Sanjay Madhav (chmmravatar)
ggaren
: review-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sanjay Madhav (chmmravatar)
Comment 1
2007-01-22 21:53:21 PST
Created
attachment 12618
[details]
patch as described
Geoffrey Garen
Comment 2
2007-01-22 22:18:23 PST
Comment on
attachment 12618
[details]
patch as described Our convention is that the caller is responsible for checking !marked() before calling mark(), so this optimization should have no effect. Do you know of a code path that marks a JSDocument before checking !marked()?
Sanjay Madhav (chmmravatar)
Comment 3
2007-01-22 22:54:09 PST
Oh, you're right. Nevermind this, closing it out. Just thought I had missed it and wanted to be certain.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug