Bug 12374 - Performance optimization to patch for Bug 10773
Summary: Performance optimization to patch for Bug 10773
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-22 21:52 PST by Sanjay Madhav (chmmravatar)
Modified: 2007-01-23 03:36 PST (History)
0 users

See Also:

Attachments
patch as described (1.03 KB, patch)
2007-01-22 21:53 PST, Sanjay Madhav (chmmravatar) 		ggaren: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sanjay Madhav (chmmravatar) 2007-01-22 21:52:31 PST 
Simple optimization: don't bother calling markDOMNodesForDocument if the JSDocument was already marked.
Comment 1 Sanjay Madhav (chmmravatar) 2007-01-22 21:53:21 PST 
Created attachment 12618 [details]
patch as described
Comment 2 Geoffrey Garen 2007-01-22 22:18:23 PST 
Comment on attachment 12618 [details]
patch as described

Our convention is that the caller is responsible for checking !marked() before calling mark(), so this optimization should have no effect.

Do you know of a code path that marks a JSDocument before checking !marked()?
Comment 3 Sanjay Madhav (chmmravatar) 2007-01-22 22:54:09 PST 
Oh, you're right. Nevermind this, closing it out. Just thought I had missed it and wanted to be certain.