Bug 12340 – XPathEvaluator behavior does not match Firefox - name() and attribute nodes

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Jesse Costello-Good]

// #2
// function name() does not work with attribute nodes

var strXML = '<data><record id="-a-" a="v">???</record><record
id="a-a">{abc}</record></data>';
var doc = (new DOMParser()).parseFromString(strXML, "text/xml");
var xpe = new XPathEvaluator();
var objResult = xpe.evaluate("//@*[name()='id']", doc, null, 0, null);
var itm = null;
var objNodes = [];
while (itm = objResult.iterateNext()) objNodes.push(itm);

assertEquals(2, objNodes.length); // Safari yields 0

[Alexey Proskuryakov]

Created attachment 12715 [details]
proposed fix

[Alexey Proskuryakov]

Created attachment 12723 [details]
proposed fix

Changed the wording of comments in the test a bit - the way name() works with a document that didn't have namespace normalization applied to it may be actually correct (at least, I couldn't find any indication that XPathEvaluator is supposed to normalize the document itself).

[Darin Adler]

Comment on attachment 12723 [details]
proposed fix

r=me

Should that be prefix.isEmpty() instead of prefix.isNull()? Is it possible to construct a test that would behave differently depending on which you used?

In general, I recommend taking advantage of the null value as distinct from empty only when it's necessary, so if either would work the same I'd prefer isEmpty.

[Alexey Proskuryakov]

Committed revision 19226.

(In reply to comment #3)
> Should that be prefix.isEmpty() instead of prefix.isNull()? Is it possible to
> construct a test that would behave differently depending on which you used?

I don't know how to make such a test; changed to isEmpty().