RESOLVED FIXED 12301
Fix the Qt build after submit 18904 
https://bugs.webkit.org/show_bug.cgi?id=12301
Summary Fix the Qt build after submit 18904
Lars Knoll
Reported 2007-01-17 07:34:46 PST
Needs a review, as the fix touches some cross platform code. It moves some methods from ImageCG.cpp into Image.cpp, makes the new drawPattern method virtual, so we can have an optimised implementation for BitmapImage, and splits draw() up into a cross platform part that checks whether it can do a solid fill instead and only after that calls a drawNative method on Image.
Attachments
See description of the bug. (18.85 KB, patch)
2007-01-17 07:36 PST, Lars Knoll 		darin: review+
DetailsFormatted DiffDiff
updated version after Darins try to fix the build (18.79 KB, patch)
2007-01-17 10:15 PST, Lars Knoll 		no flags
DetailsFormatted DiffDiff
next try (21.34 KB, patch)
2007-01-17 10:20 PST, Lars Knoll 		no flags
DetailsFormatted DiffDiff
next try... (18.36 KB, patch)
2007-01-17 11:07 PST, Lars Knoll 		no flags
DetailsFormatted DiffDiff
hopefully last try.... (17.71 KB, patch)
2007-01-17 11:12 PST, Lars Knoll 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lars Knoll
Comment 1 2007-01-17 07:36:03 PST
Created attachment 12507 [details] See description of the bug.
Darin Adler
Comment 2 2007-01-17 09:30:52 PST
Comment on attachment 12507 [details] See description of the bug. Note, our policy is that build fixes don't necessarily need review. But I guess this goes way beyond a build fix. +#include "math.h" Should be <math.h>. #include "IntRect.h" #include "MimeTypeRegistry.h" +#include "GraphicsContext.h" +#include "AffineTransform.h" Should keep these alphabetical. I believe there is a far-more-efficient way to do tiling with CG, so making drawTiled a cross-platform function may not be a good direction for the future. r=me
Lars Knoll
Comment 3 2007-01-17 10:15:32 PST
Created attachment 12514 [details] updated version after Darins try to fix the build
Lars Knoll
Comment 4 2007-01-17 10:20:57 PST
Created attachment 12516 [details] next try
Lars Knoll
Comment 5 2007-01-17 11:07:37 PST
Created attachment 12517 [details] next try...
Lars Knoll
Comment 6 2007-01-17 11:12:06 PST
Created attachment 12518 [details] hopefully last try....
Note You need to log in before you can comment on or make changes to this bug.