Bug 12301 - Fix the Qt build after submit 18904
Summary: Fix the Qt build after submit 18904
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 420+
Hardware: Other Other
: P1 Critical
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-17 07:34 PST by Lars Knoll
Modified: 2007-01-17 11:23 PST (History)
0 users

See Also:

Attachments
See description of the bug. (18.85 KB, patch)
2007-01-17 07:36 PST, Lars Knoll 		darin: review+
Details | Formatted Diff | Diff
updated version after Darins try to fix the build (18.79 KB, patch)
2007-01-17 10:15 PST, Lars Knoll 		no flags Details | Formatted Diff | Diff
next try (21.34 KB, patch)
2007-01-17 10:20 PST, Lars Knoll 		no flags Details | Formatted Diff | Diff
next try... (18.36 KB, patch)
2007-01-17 11:07 PST, Lars Knoll 		no flags Details | Formatted Diff | Diff
hopefully last try.... (17.71 KB, patch)
2007-01-17 11:12 PST, Lars Knoll 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Knoll 2007-01-17 07:34:46 PST 
Needs a review, as the fix touches some cross platform code. It moves some methods from ImageCG.cpp into Image.cpp, makes the new drawPattern method virtual, so we can have an optimised implementation for BitmapImage, and splits draw() up into a cross platform part that checks whether it can do a solid fill instead and only after that calls a drawNative method on Image.
Comment 1 Lars Knoll 2007-01-17 07:36:03 PST 
Created attachment 12507 [details]
See description of the bug.
Comment 2 Darin Adler 2007-01-17 09:30:52 PST 
Comment on attachment 12507 [details]
See description of the bug.

Note, our policy is that build fixes don't necessarily need review. But I guess this goes way beyond a build fix.

+#include "math.h"

Should be <math.h>.

 #include "IntRect.h"
 #include "MimeTypeRegistry.h"
+#include "GraphicsContext.h"
+#include "AffineTransform.h"

Should keep these alphabetical.

I believe there is a far-more-efficient way to do tiling with CG, so making drawTiled a cross-platform function may not be a good direction for the future.

r=me
Comment 3 Lars Knoll 2007-01-17 10:15:32 PST 
Created attachment 12514 [details]
updated version after Darins try to fix the build
Comment 4 Lars Knoll 2007-01-17 10:20:57 PST 
Created attachment 12516 [details]
next try
Comment 5 Lars Knoll 2007-01-17 11:07:37 PST 
Created attachment 12517 [details]
next try...
Comment 6 Lars Knoll 2007-01-17 11:12:06 PST 
Created attachment 12518 [details]
hopefully last try....