Bug 123003 - Remote Layer Tree: Proxy layer contents to the UI process
Summary: Remote Layer Tree: Proxy layer contents to the UI process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-17 17:13 PDT by Tim Horton
Modified: 2013-10-17 22:24 PDT (History)
3 users (show)

See Also:

Attachments
patch (20.90 KB, patch)
2013-10-17 17:34 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-10-17 17:13:46 PDT 
A very, very simple initial implementation of proxying (software painted) layer contents to the UI process.
Comment 1 Tim Horton 2013-10-17 17:34:14 PDT 
Created attachment 214535 [details]
patch
Comment 2 WebKit Commit Bot 2013-10-17 17:35:38 PDT 
Attachment 214535 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.h', u'Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm', u'Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.h', u'Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm']" exit_code: 1
Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.h:41:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2013-10-17 22:24:16 PDT 
http://trac.webkit.org/changeset/157623