Bug 12258 - fast/tokenizer/002 test broken
Summary: fast/tokenizer/002 test broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: LayoutTestFailure, Regression
Depends on:
Blocks:
 
Reported: 2007-01-13 09:50 PST by Alexey Proskuryakov
Modified: 2007-01-14 10:28 PST (History)
0 users

See Also:


Attachments
proposed fix (4.01 KB, patch)
2007-01-13 10:10 PST, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2007-01-13 09:50:05 PST
r18833, my fault.

-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
+layer at (0,0) size 800x34
+  RenderBlock {HTML} at (0,0) size 800x34
+    RenderBody {BODY} at (8,8) size 784x18
Comment 1 Alexey Proskuryakov 2007-01-13 10:10:08 PST
Created attachment 12417 [details]
proposed fix

I couldn't run all the tests due to bug 12251, so I suppose there will be more inconsequential changes to results outside fast/tokenizer.
Comment 2 David Kilzer (:ddkilzer) 2007-01-13 15:00:30 PST
(In reply to comment #1)
> I couldn't run all the tests due to bug 12251, so I suppose there will be more
> inconsequential changes to results outside fast/tokenizer.

The run-webkit-tests script supports an ignore test option just for this type of issue:

-i|--ignore-tests       Comma-separated list of directories or tests to ignore

Comment 3 Darin Adler 2007-01-14 06:11:09 PST
Comment on attachment 12417 [details]
proposed fix

Looks great.

I don't like that this calls writeRawData even if len is 0, though. It's also a bit unfortunate that we need to create a TextResourceDecoder even if there was no data to decode.

I'm not sure either of those is a problem. I think I'll still say r=me.
Comment 4 Alexey Proskuryakov 2007-01-14 10:28:34 PST
Committed revision 18844.

Ran the tests with the assertion disabled (proposed fix for bug 12251).