Patch forthcoming does cleanup of about half of the css files.
Created attachment 12395 [details] cleanup patch
Comment on attachment 12395 [details] cleanup patch The word "Hand" really shouldn't be capitalized in "shorthand". Do we really want braces for the for statements that don't need them? I wish our style guidelines were clear on that. If anything I'd like to see you applying even more of the m_ prefix. Hyatt was just talking about how it's hard to work on certain classes because it's so hard to tell the members apart from local variables. Fine to land this. r=me
Created attachment 12419 [details] updated patch This patch updates the previous version to address Darin's comments. Specifically, the member variables in CSSSelector have been prefixed with m_ and uses of ShortHand have been replaced with Shorthand.
Created attachment 12420 [details] patch without white space changes This version is made using svn diff -x -w for easier reviewing.
Comment on attachment 12395 [details] cleanup patch Yeah, please make sure not to capitalize the H in shorthand.
Comment on attachment 12420 [details] patch without white space changes Misplaced *: + DashboardRegion *getDashboardRegionValue () const { return m_type != CSS_DASHBOARD_REGION ? 0 : m_value.region; } r=me
Landed in r18850.