Bug 12201 – Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Rob Buis]

The testcase shows problems with hit testing of images. In this case the image above seems selected but the image below is dragged mistakenly.

[Rob Buis]

Created attachment 12349 [details]
First  attempt

This should not be so hard a patch to review... AFAICS all new test results are improvements regarding positioning info and pixel tests are same as before.
Cheers,

Rob.

[Eric Seidel (no email)]

Comment on attachment 12349 [details]
First  attempt

Glad to see this one fixed!

Bleh.  temp and ret are really bad variable names.  We should use something more descriptive.

This extra multiply is not necessary:
-        return getAspectRatio(viewBox(), viewportRect);
+        ret = getAspectRatio(viewBox(), viewportRect) * ret;

ret should be the identity there.

I'm not 100% sure this is correct.  It probably is, but I'd like to you tell me more about it over IRC.

[Rob Buis]

Created attachment 12356 [details]
Improved patch

Fixing Eric's issues.
Cheers,

Rob.

[Eric Seidel (no email)]

Comment on attachment 12356 [details]
Improved patch

This looks good.

Please add a comment about viewportTransform() not including translation.  As you mentioned on IRC, this is confusing due to <svg> and <g> both using RenderSVGContainer (and one of them having only localTransform and one having only viewportTransform())

I filed:
http://bugs.webkit.org/show_bug.cgi?id=12207
about splitting them up.

[David Kilzer (:ddkilzer)]

Landed by rwlbuis in r18760.