Bug 121707 - Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h
Summary: Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 121261
  Show dependency tree / graph
 
Reported: 2013-09-20 13:08 PDT by Zoltan Horvath
Modified: 2013-09-20 14:16 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (10.07 KB, patch)
2013-09-20 13:14 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-09-20 13:08:04 PDT 
LineBreaker and RenderTextInfo are defined in RenderBlock.h, but only
used in RenderBlockLineLayout.cpp. Moving them there (LineBreaker needs
to be a friend class of RenderBlock) in the first step in the process
of refactoring LineBreaker::NextSegmentBreak into more manageable
chunks.
Comment 1 Zoltan Horvath 2013-09-20 13:14:30 PDT 
Created attachment 212211 [details]
proposed patch
Comment 2 Dave Hyatt 2013-09-20 13:53:45 PDT 
Comment on attachment 212211 [details]
proposed patch 

r=me
Comment 3 WebKit Commit Bot 2013-09-20 14:16:45 PDT 
Comment on attachment 212211 [details]
proposed patch 

Clearing flags on attachment: 212211

Committed r156199: <http://trac.webkit.org/changeset/156199>
Comment 4 WebKit Commit Bot 2013-09-20 14:16:47 PDT 
All reviewed patches have been landed.  Closing bug.