Bug 12158 – Implement CSS3 multi column support

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

This is a bug to track CSS3 multicol support.

[Dave Hyatt]

Created attachment 12294 [details]
Implement parsing of the properties

Note that column-width and column-gap are a lot like z-index, and while adding support for them, I discovered a bug with z-index.  That's why this patch contains a z-index fix and test case. :)

[Dave Hyatt]

Created attachment 12295 [details]
Better patch for parsing of the properties.

Fixed an error in the columns shorthand parsing and made sure column-count is restricted in the parser to be non-negative.

Comment on attachment 12295 [details]
Better patch for parsing of the properties.

+        const int properties[2] = { CSS_PROP__WEBKIT_COLUMN_WIDTH, CSS_PROP__WEBKIT_COLUMN_COUNT };
+        return parseShorthand(propId, properties, 3, important);

Should be 2 instead of 3.

+    static Length initialColumnWidth() { return Length(); }

Is this supposed to be a Length? Seems to be a float everywhere else.

Actually, I guess the question is, is it really supposed to be a float everywhere else.

[Dave Hyatt]

Created attachment 12296 [details]
Revised patch addressing Eric and MItz's review comments.

[Eric Seidel (no email)]

Comment on attachment 12296 [details]
Revised patch addressing Eric and MItz's review comments.

My thoughts:

1.  You'll need lots more tests... eventually.
2.  ideally the z-index thing would be separate, but it's OK as is.
3.  Some of this new code (including the z-index stuff) could really be a macro to avoid more copy/paste trouble.  But it's OK as is.

Looks good.

[Sam Weinig]

Landed in r18660 (multi column) and r18661 (z-index).