Bug 12109 - layer visibility incorrect in some cases
Summary: layer visibility incorrect in some cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-04 04:22 PST by Antti Koivisto
Modified: 2022-01-13 23:20 PST (History)
2 users (show)

See Also:


Attachments
test case (1.97 KB, text/html)
2007-01-04 04:25 PST, Antti Koivisto
no flags Details
fixed (1.30 KB, patch)
2007-01-04 04:36 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2007-01-04 04:22:55 PST
Mishandling of sublayers in RenderLayer::updateVisibilityStatus() can cause a layer that has visible content be marked as not having any.
Comment 1 Antti Koivisto 2007-01-04 04:25:16 PST
Created attachment 12212 [details]
test case
Comment 2 Antti Koivisto 2007-01-04 04:36:44 PST
Created attachment 12214 [details]
fixed

My original visibility crawl loop is screwed up, it does not check nodes that are succeeding siblings of layered nodes.
Comment 3 Dave Hyatt 2007-01-05 00:16:21 PST
Comment on attachment 12214 [details]
fixed

r=me
Comment 4 David Kilzer (:ddkilzer) 2007-01-06 04:26:09 PST
Committed in r18616 by antti with test case LayoutTests/fast/layers/layer-visibility-sublayer.html.

Comment 5 mitz 2007-01-06 05:52:25 PST
The layout test is invalid, giving the same results with and without the patch. Reopening the bug until a valid layout test is checked in.
Comment 6 David Kilzer (:ddkilzer) 2007-01-06 07:42:36 PST
Comment on attachment 12214 [details]
fixed

Clearing hyatt's r+ so this doesn't show up in commit queue.
Comment 7 Antti Koivisto 2022-01-13 23:18:19 PST
Doesn't seem like the test was ever fixed but we likely have coverage elsewhere by now.
Comment 8 mitz 2022-01-13 23:20:03 PST
OK.