Bug 12100 – JNI bindings should be available to non-Mac platforms that have JNI

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[David Carson]

JavaScriptCore currently has the JNI bindings code lumped in with the obj-c code under the macro PLATFORM(MAC). 
Other platforms can also benefit from JNI bindings. 
The patch provided seperates out the JNI code to a HAVE_JNI define. Each platform that supports JNI can then defined HAVE_JNI to allow access to the JNI binding interfaces.

[David Carson]

Created attachment 12188 [details]
Patch to JavaScriptCore bindings

[David Carson]

Comment from weinig:
weinig: dacarson: we have a HAVE() macro in wtf/Platform.h that you should use instead of the plain #if
[1:49pm] weinig: it does
[1:49pm] dacarson: I was wondering about that - I'll take a look and switch it.
[1:49pm] weinig: #define HAVE(WTF_FEATURE) (defined( HAVE_##WTF_FEATURE ) && HAVE_##WTF_FEATURE)
[1:49pm] mitzpettel: adele: is there an "official" prefix for native slider bugs?
[1:50pm] weinig: so all you need to do is #if HAVE(JNI)

[David Carson]

Created attachment 12195 [details]
Updated patch to address weinig's comments

[Darin Adler]

Comment on attachment 12195 [details]
Updated patch to address weinig's comments

There's a tab in the change log. Otherwise looks fine.

r=me

[David Kilzer (:ddkilzer)]

Committed revision 18657.