Bug 12100 - JNI bindings should be available to non-Mac platforms that have JNI
Summary: JNI bindings should be available to non-Mac platforms that have JNI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Other Other
: P2 Normal
Assignee: David Carson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-03 09:00 PST by David Carson
Modified: 2007-01-07 21:27 PST (History)
0 users

See Also:


Attachments
Patch to JavaScriptCore bindings (4.06 KB, patch)
2007-01-03 09:14 PST, David Carson
no flags Details | Formatted Diff | Diff
Updated patch to address weinig's comments (4.06 KB, patch)
2007-01-03 12:28 PST, David Carson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Carson 2007-01-03 09:00:03 PST
JavaScriptCore currently has the JNI bindings code lumped in with the obj-c code under the macro PLATFORM(MAC). 
Other platforms can also benefit from JNI bindings. 
The patch provided seperates out the JNI code to a HAVE_JNI define. Each platform that supports JNI can then defined HAVE_JNI to allow access to the JNI binding interfaces.
Comment 1 David Carson 2007-01-03 09:14:03 PST
Created attachment 12188 [details]
Patch to JavaScriptCore bindings
Comment 2 David Carson 2007-01-03 12:17:00 PST
Comment from weinig:
weinig: dacarson: we have a HAVE() macro in wtf/Platform.h that you should use instead of the plain #if
[1:49pm] weinig: it does
[1:49pm] dacarson: I was wondering about that - I'll take a look and switch it.
[1:49pm] weinig: #define HAVE(WTF_FEATURE) (defined( HAVE_##WTF_FEATURE ) && HAVE_##WTF_FEATURE)
[1:49pm] mitzpettel: adele: is there an "official" prefix for native slider bugs?
[1:50pm] weinig: so all you need to do is #if HAVE(JNI)
Comment 3 David Carson 2007-01-03 12:28:28 PST
Created attachment 12195 [details]
Updated patch to address weinig's comments
Comment 4 Darin Adler 2007-01-06 17:18:46 PST
Comment on attachment 12195 [details]
Updated patch to address weinig's comments

There's a tab in the change log. Otherwise looks fine.

r=me
Comment 5 David Kilzer (:ddkilzer) 2007-01-07 21:27:42 PST
Committed revision 18657.