Bug 12049 - RenderBlock::calcMinMaxWidth() should not examine children of fixed-width blocks
Summary: RenderBlock::calcMinMaxWidth() should not examine children of fixed-width blocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-31 14:15 PST by mitz
Modified: 2006-12-31 17:05 PST (History)
0 users

See Also:

Attachments
Optimize (3.15 KB, patch)
2006-12-31 14:20 PST, mitz 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-12-31 14:15:38 PST 
Patch forthcoming.
Comment 1 mitz 2006-12-31 14:20:07 PST 
Created attachment 12138 [details]
Optimize
Comment 2 mitz 2006-12-31 14:25:37 PST 
Comment on attachment 12138 [details]
Optimize

No layout test regressions.
Comment 3 Dave Hyatt 2006-12-31 14:28:43 PST 
Comment on attachment 12138 [details]
Optimize

I started trickling support for the intrinsic and min-intrinsic keywords into flexible boxes.  min-width: intrinsic, for example, would mean you need to check the kids still.

I'm not sure we need to deal with this now... but a FIXME reminding us that we need to deal with this issue when fully implementing these keywords might be helpful.
Comment 4 Dave Hyatt 2006-12-31 14:30:07 PST 
This optimization is valid for flexible boxes too.
Comment 5 Dave Hyatt 2006-12-31 14:55:20 PST 
Another point to make is that I would like to eventually exclude "self-width/min-width/max-width" checks and only use them for your children (and not yourself).  As long as they are included in self-calculations, flexible boxes will be broken.

Anyway, just getting my thoughts down where someone else can absorb them. :)
Comment 6 Dave Hyatt 2006-12-31 14:55:43 PST 
Comment on attachment 12138 [details]
Optimize

r=me
Comment 7 David Kilzer (:ddkilzer) 2006-12-31 17:05:03 PST 
Committed revision 18497.