Bug 12035 - Use SVGParserUtilities in lists of values
Summary: Use SVGParserUtilities in lists of values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-30 07:36 PST by Rob Buis
Modified: 2006-12-30 13:08 PST (History)
0 users

See Also:

Attachments
First attempt (24.33 KB, patch)
2006-12-30 07:43 PST, Rob Buis 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2006-12-30 07:36:44 PST 
There are some places where svg needs to parse things into a list or parse a special list, namely
value followed by optional value.
Comment 1 Rob Buis 2006-12-30 07:43:26 PST 
Created attachment 12118 [details]
First attempt

This should be a simple change. I think the existing testcases are enough for this functionality.
Cheers,

Rob.
Comment 2 Sam Weinig 2006-12-30 11:14:41 PST 
Comment on attachment 12118 [details]
First attempt

Looks good to me.  The only nit is that you should remove this line from the ChangeLog,

+        WARNING: NO TEST CASES ADDED OR CHANGED

otherwise, r+!
Comment 3 Rob Buis 2006-12-30 13:08:41 PST 
Landed in r18487.