WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
12028
Adapt viewBox parsing to SVGParserUtilities
https://bugs.webkit.org/show_bug.cgi?id=12028
Summary
Adapt viewBox parsing to SVGParserUtilities
Rob Buis
Reported
Friday, December 29, 2006 12:51:08 PM UTC
Adapt the viewBox parsing code to use parseNumber and friends and add a testcase for viewBox parsing.
Attachments
First attempt
(51.10 KB, patch)
2006-12-29 04:58 PST
,
Rob Buis
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Rob Buis
Comment 1
Friday, December 29, 2006 12:58:50 PM UTC
Created
attachment 12102
[details]
First attempt This patch should do it. Please note that one of the end goals is to remove the old svgpathparser. Cheers, Rob.
Eric Seidel (no email)
Comment 2
Friday, December 29, 2006 8:05:56 PM UTC
Comment on
attachment 12102
[details]
First attempt Looks great. You should add some "valid" tests before landing. To make sure that things like " 0 0 30 40 " and "0 0 30,40" work
Rob Buis
Comment 3
Friday, December 29, 2006 9:02:25 PM UTC
Landed in
r18478
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug