Bug 12019 - Patch to make Qt Platform build again
Summary: Patch to make Qt Platform build again
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-28 16:52 PST by Daniel Molkentin
Modified: 2006-12-28 18:13 PST (History)
0 users

See Also:

Attachments
Patch to make the Qt platform on Webkit build again (15.19 KB, patch)
2006-12-28 16:54 PST, Daniel Molkentin 		eric: review-
Details | Formatted Diff | Diff
Added ChangeLog, removed useless PDFDocumentImage stub (11.96 KB, patch)
2006-12-28 17:42 PST, Daniel Molkentin 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Molkentin 2006-12-28 16:52:40 PST 
Patch from Fredrik Höglund <fredrik@kde.org>, extended by me (Daniel Molkentin <molkentin@kde.org>):

 * Fix font sizes
 * Make Qt plattform build again:
   * Adjust Qt platform to the Image class split.
   * Introduce BitmapImage class
   * add stub PDFDocumentImage class

Patch attached.
Comment 1 Daniel Molkentin 2006-12-28 16:54:01 PST 
Created attachment 12091 [details]
Patch to make the Qt platform on Webkit build again
Comment 2 David Kilzer (:ddkilzer) 2006-12-28 17:07:34 PST 
Comment on attachment 12091 [details]
Patch to make the Qt platform on Webkit build again

Setting review? flag.
Comment 3 Eric Seidel (no email) 2006-12-28 17:20:55 PST 
Comment on attachment 12091 [details]
Patch to make the Qt platform on Webkit build again

There should be no need to add PDFDocumentImage.  Otherwise the patch looks fine.

You'll need to add a ChangeLog entry.  prepare-ChangeLog (a perl script included in WebKitTools/Scripts) will generate a changelog stub entry for you.
Comment 4 Daniel Molkentin 2006-12-28 17:42:25 PST 
Created attachment 12093 [details]
Added ChangeLog, removed useless PDFDocumentImage stub
Comment 5 Eric Seidel (no email) 2006-12-28 18:10:16 PST 
Comment on attachment 12093 [details]
Added ChangeLog, removed useless PDFDocumentImage stub

Looks great!  r=me.
Comment 6 Eric Seidel (no email) 2006-12-28 18:13:03 PST 
Landed in r18463.