Bug 11998 – Incorrect serialization of quotation marks in XML attributes.

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Une Bévue]

seems to be due to this XPath syntax :

<a>
  <xsl:attribute name="href">
    <xsl:value-of select="concat('javascript:setPage(&quot;',link,'&quot;);')"/>
  </xsl:attribute>
  <xsl:value-of select="label"/>
</a>

notice exactly same syntax works within Firefox 2 and Opera 9.1

[Alexey Proskuryakov]

Created attachment 12068 [details]
test case

The problem is that XSLTProcessor re-parses the stylesheet (evil!), while serializer handles quotation marks incorrectly. Here is a workaround:
<xsl:value-of select="concat('javascript:setPage(%22',link,'%22);')"/>

See also: bug 11947.

[Alexey Proskuryakov]

Created attachment 12110 [details]
proposed fix

Comment on attachment 12110 [details]
proposed fix

+      document.getElementById("result").textContent += ": " + (new XMLSerializer()).serializeToString(document.getElementsByTagName('div')[1]);

Doesn't work so well with the initial text in result (I guess originally it was just FAIL)

The patch looks very straightforward, so assuming it doesn't affect any existing tests, r=me.

[Alexey Proskuryakov]

Committed revision 18484.

(In reply to comment #3)

> Doesn't work so well with the initial text in result (I guess originally it was
> just FAIL)

Oops, indeed. Fixed.