Bug 11941 - REGRESSION: Missing text stroke in svg/W3C-SVG-1.1/text-deco-01-b.svg
Summary: REGRESSION: Missing text stroke in svg/W3C-SVG-1.1/text-deco-01-b.svg
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL:
Keywords: InRadar, LayoutTestFailure, Regression
: 12012 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-12-23 01:19 PST by mitz
Modified: 2007-06-12 10:52 PDT (History)
2 users (show)

See Also:


Attachments
first attempt (44.88 KB, patch)
2007-01-01 05:32 PST, Rob Buis
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-12-23 01:19:37 PST
svg/W3C-SVG-1.1/text-deco-01-b.svg is failing in pixel mode. Some of the text is not stroked.
Comment 1 mitz 2006-12-27 12:27:27 PST
In r18436 a new version of text-deco-01-b.svg was checked in along with results generated with TOT, so the regression may no longer be causing a test failure. When fixing this bug (or sooner), updated results should be generated and checked in.
Comment 2 mitz 2006-12-28 04:37:34 PST
*** Bug 12012 has been marked as a duplicate of this bug. ***
Comment 3 mitz 2006-12-28 04:48:02 PST
As a quick fix for the regression, you can restore stroke thickness to whatever it was before returning from InlineFlowBox::paintDecorations(). That would still leave the text decorations broken, but no more broken than they used to be (SVG text decorations should be filled and stroked, with both fill and stroke being behind or in front of the text, depending on the decoration).
Comment 4 Rob Buis 2007-01-01 05:32:06 PST
Created attachment 12141 [details]
first attempt

This should fix it. AFAICS only this test is really affected.
Cheers,

Rob.
Comment 5 Oliver Hunt 2007-01-01 23:51:52 PST
Comment on attachment 12141 [details]
first attempt

should
+//            const_cast<RenderObject*>(object)->style()->setTextFillColor(Color());
really be Color()?
Comment 6 Dave Hyatt 2007-01-02 00:01:38 PST
Comment on attachment 12141 [details]
first attempt

I assume you need to still do setColor() down both code paths?

 If stroke/fill is invalid in CSS, then color is used again.
Comment 7 Eric Seidel (no email) 2007-01-12 17:25:54 PST
Comment on attachment 12141 [details]
first attempt

Um... I don't think we're supposed to be mutating RenderStyles.  I think this just came up when talking to hyatt on IRC.
Comment 8 Maciej Stachowiak 2007-01-29 03:50:16 PST
<rdar://problem/4960653>
Comment 9 Nikolas Zimmermann 2007-05-16 15:22:37 PDT
The new SVG text engine fixes this problem.

*** This bug has been marked as a duplicate of 12698 ***
Comment 10 mitz 2007-05-23 01:15:16 PDT
Reopening because this is not fixed on trunk after bug 12698 was fixed on the feature branch.
Comment 11 Eric Seidel (no email) 2007-06-12 10:44:55 PDT
This is definitely fixed on feature branch.
Comment 12 mitz 2007-06-12 10:52:25 PDT
(In reply to comment #11)
> This is definitely fixed on feature branch.

Yet broken on trunk. I think bugzilla tracks trunk, which is why I reopened.