Bug 11930 - Specifying border-radius makes the outline shrink
Summary: Specifying border-radius makes the outline shrink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords: EasyFix, HasReduction
Depends on:
Blocks:
 
Reported: 2006-12-22 07:35 PST by mitz
Modified: 2006-12-27 15:40 PST (History)
1 user (show)

See Also:

Attachments
Test case (225 bytes, text/html)
2006-12-22 07:35 PST, mitz 		no flags Details
Prevent fallthrough (1014 bytes, patch)
2006-12-26 09:14 PST, mitz 		ggaren: review+
Details | Formatted Diff | Diff
Prevent fallthrough (27.58 KB, patch)
2006-12-26 12:03 PST, mitz 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-12-22 07:35:16 PST 
An object's outline is inset by 1 pixel if the -webkit-border-radius property is specified, even if the specified value is 0 and there is no border. See test case.
Comment 1 mitz 2006-12-22 07:35:50 PST 
Created attachment 11967 [details]
Test case
Comment 2 mitz 2006-12-22 08:23:41 PST 
This is caused by a missing return at the end of the CSS_PROP__WEBKIT_BORDER_BOTTOM_RIGHT_RADIUS case in CSSStyleSelector::applyProperty(), causing fallthrough to the CSS_PROP_OUTLINE_OFFSET case.
Comment 3 mitz 2006-12-26 09:14:24 PST 
Created attachment 12034 [details]
Prevent fallthrough

Let me know if a regression test is needed.
Comment 4 Geoffrey Garen 2006-12-26 10:34:14 PST 
Comment on attachment 12034 [details]
Prevent fallthrough

The policy is that all patches should come with a regression test unless it's really not feasible or there's no change in behavior.

I'll r+ this, but please land it with a test.
Comment 5 mitz 2006-12-26 12:03:04 PST 
Created attachment 12040 [details]
Prevent fallthrough

Added pixel test.
Comment 6 Geoffrey Garen 2006-12-26 12:14:40 PST 
Comment on attachment 12040 [details]
Prevent fallthrough

r=me
Comment 7 Sam Weinig 2006-12-27 15:40:56 PST 
Landed in r18442.