WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
11930
Specifying border-radius makes the outline shrink
https://bugs.webkit.org/show_bug.cgi?id=11930
Summary
Specifying border-radius makes the outline shrink
mitz
Reported
Friday, December 22, 2006 3:35:16 PM UTC
An object's outline is inset by 1 pixel if the -webkit-border-radius property is specified, even if the specified value is 0 and there is no border. See test case.
Attachments
Test case
(225 bytes, text/html)
2006-12-22 07:35 PST
,
mitz
no flags
Details
Prevent fallthrough
(1014 bytes, patch)
2006-12-26 09:14 PST
,
mitz
ggaren
: review+
Details
Formatted Diff
Diff
Prevent fallthrough
(27.58 KB, patch)
2006-12-26 12:03 PST
,
mitz
ggaren
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
mitz
Comment 1
Friday, December 22, 2006 3:35:50 PM UTC
Created
attachment 11967
[details]
Test case
mitz
Comment 2
Friday, December 22, 2006 4:23:41 PM UTC
This is caused by a missing return at the end of the CSS_PROP__WEBKIT_BORDER_BOTTOM_RIGHT_RADIUS case in CSSStyleSelector::applyProperty(), causing fallthrough to the CSS_PROP_OUTLINE_OFFSET case.
mitz
Comment 3
Tuesday, December 26, 2006 5:14:24 PM UTC
Created
attachment 12034
[details]
Prevent fallthrough Let me know if a regression test is needed.
Geoffrey Garen
Comment 4
Tuesday, December 26, 2006 6:34:14 PM UTC
Comment on
attachment 12034
[details]
Prevent fallthrough The policy is that all patches should come with a regression test unless it's really not feasible or there's no change in behavior. I'll r+ this, but please land it with a test.
mitz
Comment 5
Tuesday, December 26, 2006 8:03:04 PM UTC
Created
attachment 12040
[details]
Prevent fallthrough Added pixel test.
Geoffrey Garen
Comment 6
Tuesday, December 26, 2006 8:14:40 PM UTC
Comment on
attachment 12040
[details]
Prevent fallthrough r=me
Sam Weinig
Comment 7
Wednesday, December 27, 2006 11:40:56 PM UTC
Landed in
r18442
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug