CSSMediaRule functions insertRule and deleteRule assert when called from js in debug builds

[Sam Weinig]

Test case to come

[Sam Weinig]

Created attachment 11940 [details]
testcase

[David Kilzer (:ddkilzer)]

Is this related to Bug 11891?

[Alexey Proskuryakov]

I don't see the relation to bug 11891 (yet?).

This assertion failure is here:

JSValue* DOMCSSRule::getValueProperty(ExecState* exec, int token) const
{
  CSSRule &cssRule = *m_impl;
  switch (token) {
<...>
  default:
    assert(0);

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> I don't see the relation to bug 11891 (yet?).

Please ignore my earlier comment.  The only link between the two is that they're CSS-related.

[Rob Buis]

Hi Alexey,

Correct, however it should not end up in that function in the first place :) After some research I have a fix. A patch is coming up later today.
Cheers,

Rob.
(In reply to comment #3)
> I don't see the relation to bug 11891 (yet?).
> 
> This assertion failure is here:
> 
> JSValue* DOMCSSRule::getValueProperty(ExecState* exec, int token) const
> {
>   CSSRule &cssRule = *m_impl;
>   switch (token) {
> <...>
>   default:
>     assert(0);
> 

[Rob Buis]

Created attachment 11950 [details]
First attempt

This works :) I hope it is okay to test this way, since it is custom bindings code.
Cheers,

Rob.

[Rob Buis]

Created attachment 11952 [details]
Now with comment

Added a comment explaining the fix.
Cheers,

Rob.

[Anders Carlsson]

Comment on attachment 11952 [details]
Now with comment

Me and Rob discussed some changes on IRC. r=me

[Rob Buis]

Landed in r18376.