Bug 11870 – Bug 11866 caused layout test regression in fast/forms/input-value.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[David Kilzer (:ddkilzer)]

The patch for Bug 11866 caused a layout test regression in fast/forms/input-value.html.

http://build.webkit.org/results/post-commit-powerpc-mac-os-x/4737/

[David Kilzer (:ddkilzer)]

Looks like the expected results just need to be updated.

[Kirby White]

If the goal is to match IE or Gecko, then it should have "after" in the second column for "hidden with value property changed", and this is a regression.  If the goal is to make sense, then I'd argue for "before", to match text and password fields.

I suppose trying to make sense is a bit quixotic here.

[Kirby White]

The two problems (the layout test failing now, and all three of those input types' attributes not doing what IE does) seem like separate issues to me.

What if I change the expected results to show "before" in the second column for hidden fields, just as they do for text and password fields, and then file a new bug to change the behavior of all three types to match what IE does?

[Mark Rowe (bdash)]

That sounds fine to me.

[Mark Rowe (bdash)]

Created attachment 11912 [details]
Patch with updated results.

[Brady Eidson]

Comment on attachment 11912 [details]
Patch with updated results.

Okay!

[Mark Rowe (bdash)]

Landed in r18292.  Kirby, can you please file the followup bug?

[Kirby White]

Filed as bug 11871.